Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Fix Tests from #4479#4512

Merged
adityapatwardhan merged 2 commits into
PowerShell:masterPowerShell/PowerShell:masterfrom
markekraus:WebCmdletTestFixmarkekraus/PowerShell:WebCmdletTestFixCopy head branch name to clipboard
Aug 7, 2017
Merged

Fix Tests from #4479#4512
adityapatwardhan merged 2 commits into
PowerShell:masterPowerShell/PowerShell:masterfrom
markekraus:WebCmdletTestFixmarkekraus/PowerShell:WebCmdletTestFixCopy head branch name to clipboard

Conversation

@markekraus

Copy link
Copy Markdown
Contributor

My Bad... the tests I had in #4479 were failing in the nightly. This fixes them and now they now pass and fail for the right reasons.

@msftclas

msftclas commented Aug 6, 2017

Copy link
Copy Markdown

@markekraus,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by Microsoft. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

@adityapatwardhan

Copy link
Copy Markdown
Member

@markekraus Thanks for fixing the tests. Can you run 'Feature' tests to validate that all the required tests are executed.

The documentation for executing additional tests is at: https://github.com/PowerShell/PowerShell/blob/master/docs/testing-guidelines/testing-guidelines.md

Look for the section titled 'Requesting additional tests for a PR'

@adityapatwardhan

Copy link
Copy Markdown
Member

@markekraus I have pushed an empty commit to execute the feature tests.

@markekraus

Copy link
Copy Markdown
Contributor Author

@adityapatwardhan Thank you. I will make sure to do this in the future.

@markekraus

markekraus commented Aug 7, 2017

Copy link
Copy Markdown
Contributor Author

@adityapatwardhan

Copy link
Copy Markdown
Member

@markekraus Restarted the tests on Travis CI.

@markekraus

Copy link
Copy Markdown
Contributor Author

@adityapatwardhan

Copy link
Copy Markdown
Member

@daxian-dbw Can you have a quick look? This fixes the daily build failure.

@adityapatwardhan adityapatwardhan merged commit e4060ab into PowerShell:master Aug 7, 2017
@adityapatwardhan

Copy link
Copy Markdown
Member

@markekraus Thanks for fixing the tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.