Extend -SkipHeaderValidation to include -UserAgent to support non-standard User-Agent headers#4479
Merged
TravisEz13 merged 2 commits intoAug 4, 2017
PowerShell:masterPowerShell/PowerShell:masterfrom
markekraus:UserAgentSkipValidationmarkekraus/PowerShell:UserAgentSkipValidationCopy head branch name to clipboard
Merged
Extend -SkipHeaderValidation to include -UserAgent to support non-standard User-Agent headers#4479TravisEz13 merged 2 commits intoPowerShell:masterPowerShell/PowerShell:masterfrom markekraus:UserAgentSkipValidationmarkekraus/PowerShell:UserAgentSkipValidationCopy head branch name to clipboard
TravisEz13 merged 2 commits into
PowerShell:masterPowerShell/PowerShell:masterfrom
markekraus:UserAgentSkipValidationmarkekraus/PowerShell:UserAgentSkipValidationCopy head branch name to clipboard
Conversation
|
@markekraus, |
SteveL-MSFT
requested changes
Aug 4, 2017
SteveL-MSFT
left a comment
Member
There was a problem hiding this comment.
Thanks for the contribution, just one requested change
|
|
||
| try { | ||
| if ($Cmdlet -eq 'Invoke-WebRequest') { | ||
| $result.Output = Invoke-WebRequest -Uri $Uri -TimeoutSec 5 -UserAgent $UserAgent -SkipHeaderValidation:$SkipHeaderValidation.IsPresent |
Member
There was a problem hiding this comment.
Instead of duplicating all the parameters, you should use splatting:
$args = @{Uri=$uri;Timeout=5;UserAgent=$useragent;...}
Invoke-WebRequest @args
Invoke-RestMethod @args
Contributor
Author
There was a problem hiding this comment.
Used $Params instead of $args to avoid conflicts with the automatic variable.
markekraus
added a commit
to markekraus/PowerShell
that referenced
this pull request
Aug 6, 2017
Merged
adityapatwardhan
pushed a commit
that referenced
this pull request
Aug 7, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Synopsis
Extends #4085 to include the
-UserAgentparameter suppliedUser-Agentheader.Description
Some API's, such as Reddit require special
User-Agentheaders to identify application consumers of the API. Currently,Invoke-WebRequestandInvoke-RestMethodare unable to properly use non-compliantUser-Agentheaders. This extends the behavior of the-SkipHeaderValidationswitch parameter to include theUser-Agentheader supplied by the-UserAgentparameter.Test Code
Current Behavior:
New Behavior