Updated FileSystem Provider to Split UNC Paths#2713
Closed
dchristian3188 wants to merge 2 commits into
PowerShell:masterPowerShell/PowerShell:masterfrom
dchristian3188:masterCopy head branch name to clipboard
Closed
Updated FileSystem Provider to Split UNC Paths#2713dchristian3188 wants to merge 2 commits intoPowerShell:masterPowerShell/PowerShell:masterfrom dchristian3188:masterCopy head branch name to clipboard
dchristian3188 wants to merge 2 commits into
PowerShell:masterPowerShell/PowerShell:masterfrom
dchristian3188:masterCopy head branch name to clipboard
Conversation
|
Hi @dchristian3188, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution! The agreement was validated by Microsoft and real humans are currently evaluating your PR. TTYL, MSBOT; |
iSazonov
reviewed
Nov 18, 2016
| } | ||
|
|
||
| It 'Returns a multilevel path child' { | ||
| Split-Path -Path 'C:\Temp\folder1' -Leaf | Should be 'folder1' |
Collaborator
There was a problem hiding this comment.
Please use variables for repeated constants and move initializations into BeforeAll.
| } | ||
|
|
||
| It 'Splits a single level path' { | ||
| Split-Path -Path 'C:\Temp' | Should be 'C:\' |
| { | ||
| parentPath = EnsureDriveIsRooted(parentPath); | ||
| } | ||
| } |
Contributor
Author
|
Thanks iSazonov, never used test cases before. Changes uploaded. |
Collaborator
|
@dchristian3188 Thanks! Maybe these tests would have to be here and then we need to bring them to the format of those tests. Wait for the PG conclusion. |
Contributor
Author
|
re-opened under #2788. Sorry new to branching... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently splitting a UNC root on windows will return a empty string.
Please reference:
#2301