Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Add completers for the Property parameter for Compare-Object and ConvertTo-Html#25233

Open
MartinGC94 wants to merge 1 commit into
PowerShell:masterPowerShell/PowerShell:masterfrom
MartinGC94:CompletersForObjectCmdsMartinGC94/PowerShell:CompletersForObjectCmdsCopy head branch name to clipboard
Open

Add completers for the Property parameter for Compare-Object and ConvertTo-Html#25233
MartinGC94 wants to merge 1 commit into
PowerShell:masterPowerShell/PowerShell:masterfrom
MartinGC94:CompletersForObjectCmdsMartinGC94/PowerShell:CompletersForObjectCmdsCopy head branch name to clipboard

Conversation

@MartinGC94

Copy link
Copy Markdown
Contributor

PR Summary

This PR adds completers for the Property parameter of Compare-Object and ConvertTo-Html. This includes both the simple use like: ls | ConvertTo-Html -Property Na<Tab> and the calculated property use: ls | ConvertTo-Html -Property @{Labe<Tab>}
I haven't added any tests as this is just adding new items to an existing list (well, switch) of commands to complete with existing completers.

PR Context

PR Checklist

@iSazonov

Copy link
Copy Markdown
Collaborator

I haven't added any tests as this is just adding new items to an existing list (well, switch) of commands to complete with existing completers.

Have we tests for these existing completers?

@iSazonov

Copy link
Copy Markdown
Collaborator

@MartinGC94 Please see #25234 It was created after conversation with @daxian-dbw I don't remember who asked me - you or @ArmaanMcleod - but now we have exact roadmap.

@MartinGC94

MartinGC94 commented Mar 25, 2025

Copy link
Copy Markdown
Contributor Author

I haven't added any tests as this is just adding new items to an existing list (well, switch) of commands to complete with existing completers.

Have we tests for these existing completers?

Yes there should be. The MemberName completer is used by a lot of different commands. The GetSpecialHashTableKeyMembers method was updated by me and I see a test with Get-WinEvent here: https://github.com/PowerShell/PowerShell/pull/16498/files and I know I've made other PRs with tests in that area as well.

GitHub
PR Summary Fixes a few things about hashtable completion:

Use partial input to filter the suggested keys
Filters out keys that have already been specified in the hashtable
Allows hashtable key com...

@microsoft-github-policy-service microsoft-github-policy-service Bot added the Review - Needed The PR is being reviewed label Apr 1, 2025
@microsoft-github-policy-service

Copy link
Copy Markdown
Contributor

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Review - Needed The PR is being reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.