Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Preferred way to create completers for in-box cmdlets #25234

Copy link
Copy link
@iSazonov

Description

@iSazonov
Issue body actions

Summary of the new feature / enhancement

We have CompletionCompleters.cs file with gigantic size. There's a lot of code for in-box cmdlet completers. That's how it happened historically.

Now we have ArgumentCompleterAttribute and IArgumentCompleter and it is preferable to use them

  1. to create new specific cmdlet completers
  2. to migrate existing code (Then, ideally, CompletionCompleters.cs file would contain only code related to language constructs as it should be.)

This will not only allow us to reduce the size of this file. We will be able to unify the code, remove duplication, add more tests, and distinguish common code that can be made public in the future so that users can use it in their projects.

It is also a step towards the decoupling of modules #9960

/cc @daxian-dbw @ArmaanMcleod @MartinGC94

Proposed technical implementation details (optional)

No response

Reactions are currently unavailable

Metadata

Metadata

Assignees

No one assigned

    Labels

    Issue-Code Cleanupthe issue is for cleaning up the code with no impact on functionalitythe issue is for cleaning up the code with no impact on functionalityIssue-Enhancementthe issue is more of a feature request than a bugthe issue is more of a feature request than a bugResolution-No ActivityIssue has had no activity for 6 months or moreIssue has had no activity for 6 months or moreUp-for-GrabsUp-for-grabs issues are not high priorities, and may be opportunities for external contributorsUp-for-grabs issues are not high priorities, and may be opportunities for external contributors
    No fields configured for Feature.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      Morty Proxy This is a proxified and sanitized view of the page, visit original site.