Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Fix the definition of the PDH_COUNTER_INFO struct#17779

Merged
PaulHigin merged 2 commits into
PowerShell:masterPowerShell/PowerShell:masterfrom
SeeminglyScience:fix-pdh-counter-infoSeeminglyScience/PowerShell:fix-pdh-counter-infoCopy head branch name to clipboard
Jul 27, 2022
Merged

Fix the definition of the PDH_COUNTER_INFO struct#17779
PaulHigin merged 2 commits into
PowerShell:masterPowerShell/PowerShell:masterfrom
SeeminglyScience:fix-pdh-counter-infoSeeminglyScience/PowerShell:fix-pdh-counter-infoCopy head branch name to clipboard

Conversation

@SeeminglyScience

Copy link
Copy Markdown
Contributor

PR Summary

Fixes the crash from #13829

PR Context

The definition is mostly generated via dotnet/ClangSharp and altered a little manually. It's a bit involved for a struct we only use two fields from but it's easy to include in full so if we end up needing more this makes it very easy.

PR Checklist

@ghost ghost assigned PaulHigin Jul 26, 2022
@iSazonov iSazonov added CL-Test Indicates that a PR should be marked as a test change in the Change Log CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log and removed CL-Test Indicates that a PR should be marked as a test change in the Change Log labels Jul 27, 2022
@adityapatwardhan

adityapatwardhan commented Jul 27, 2022

Copy link
Copy Markdown
Member

@SeeminglyScience please fix the CodeFactor issue if they were introduced in this PR: https://www.codefactor.io/repository/github/powershell/powershell/pull/17779

Quality software, faster.

@adityapatwardhan

Copy link
Copy Markdown
Member

@SeeminglyScience can you validate the change on x86 and arm64? We do not run CI on those platforms.

@SeeminglyScience

SeeminglyScience commented Jul 27, 2022

Copy link
Copy Markdown
Contributor Author

@SeeminglyScience can you validate the change on x86 and arm64? We do not run CI on those platforms.

Tested in x86, looks good. Arm64 I don't have the ability to test afaik Checking with Steve who has an Arm64 device

@SeeminglyScience

Copy link
Copy Markdown
Contributor Author

@adityapatwardhan Verified with Steve that Arm64 works as well 🎉

Comment thread src/Microsoft.PowerShell.Commands.Diagnostics/PdhHelper.cs
@PaulHigin PaulHigin merged commit b780a34 into PowerShell:master Jul 27, 2022
@SeeminglyScience SeeminglyScience deleted the fix-pdh-counter-info branch July 27, 2022 20:36
@ghost

ghost commented Aug 12, 2022

Copy link
Copy Markdown

🎉v7.3.0-preview.7 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.