Skip Counter tests on 32bit operating system#17691
Skip Counter tests on 32bit operating system#17691adityapatwardhan wants to merge 1 commit intoPowerShell:masterPowerShell/PowerShell:masterfrom adityapatwardhan:DisableCounterx86adityapatwardhan/PowerShell:DisableCounterx86Copy head branch name to clipboard
Conversation
|
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
|
Looking at the issue, it seems @SeeminglyScience has a proposed fix. Can we take that instead of skipping the tests since actual use of the cmdlet will still crash, right? |
Didn't notice the proposed fix in the issue.
|
@SeeminglyScience friendly ping. |
|
Chatted with @adityapatwardhan and @SeeminglyScience offline, and we agreed to merge this one first and @SeeminglyScience will re-enable the test when getting the fix in. |
|
/azp rebase |
|
Command 'rebase' is not supported by Azure Pipelines. Supported commands
See additional documentation. |
2b00d7f to
ba22082
Compare
|
Superseded by #17779 |
PR Summary
Skip counter tests on 32bit windows operating system due to crash reported here: #13829
PR Context
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.(which runs in a different PS Host).