Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Skip Counter tests on 32bit operating system#17691

Closed
adityapatwardhan wants to merge 1 commit into
PowerShell:masterPowerShell/PowerShell:masterfrom
adityapatwardhan:DisableCounterx86adityapatwardhan/PowerShell:DisableCounterx86Copy head branch name to clipboard
Closed

Skip Counter tests on 32bit operating system#17691
adityapatwardhan wants to merge 1 commit into
PowerShell:masterPowerShell/PowerShell:masterfrom
adityapatwardhan:DisableCounterx86adityapatwardhan/PowerShell:DisableCounterx86Copy head branch name to clipboard

Conversation

@adityapatwardhan

@adityapatwardhan adityapatwardhan commented Jul 15, 2022

Copy link
Copy Markdown
Member

PR Summary

Skip counter tests on 32bit windows operating system due to crash reported here: #13829

PR Context

PR Checklist

@pull-request-quantifier-deprecated

Copy link
Copy Markdown

This PR has 3 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Extra Small
Size       : +2 -1
Percentile : 1.2%

Total files changed: 1

Change summary by file extension:
.ps1 : +2 -1

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detetcted.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

@ghost ghost assigned iSazonov Jul 15, 2022
@SteveL-MSFT

Copy link
Copy Markdown
Member

Looking at the issue, it seems @SeeminglyScience has a proposed fix. Can we take that instead of skipping the tests since actual use of the cmdlet will still crash, right?

daxian-dbw
daxian-dbw previously approved these changes Jul 19, 2022
@daxian-dbw daxian-dbw dismissed their stale review July 19, 2022 00:27

Didn't notice the proposed fix in the issue.

@iSazonov

Copy link
Copy Markdown
Collaborator

@SeeminglyScience friendly ping.

@daxian-dbw

Copy link
Copy Markdown
Member

Chatted with @adityapatwardhan and @SeeminglyScience offline, and we agreed to merge this one first and @SeeminglyScience will re-enable the test when getting the fix in.

@adityapatwardhan

Copy link
Copy Markdown
Member Author

/azp rebase

@azure-pipelines

Copy link
Copy Markdown
Command 'rebase' is not supported by Azure Pipelines.

Supported commands
  • help:
    • Get descriptions, examples and documentation about supported commands
    • Example: help "command_name"
  • list:
    • List all pipelines for this repository using a comment.
    • Example: "list"
  • run:
    • Run all pipelines or specific pipelines for this repository using a comment. Use this command by itself to trigger all related pipelines, or specify specific pipelines to run.
    • Example: "run" or "run pipeline_name, pipeline_name, pipeline_name"
  • where:
    • Report back the Azure DevOps orgs that are related to this repository and org
    • Example: "where"

See additional documentation.

@SeeminglyScience

Copy link
Copy Markdown
Contributor

Superseded by #17779

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.