Use OrdinalIgnoreCase in CommandLineParser#14303
Merged
daxian-dbw merged 1 commit intoDec 3, 2020
PowerShell:masterPowerShell/PowerShell:masterfrom
iSazonov:perf-commandlineparseriSazonov/PowerShell:perf-commandlineparserCopy head branch name to clipboard
Merged
Use OrdinalIgnoreCase in CommandLineParser#14303daxian-dbw merged 1 commit intoPowerShell:masterPowerShell/PowerShell:masterfrom iSazonov:perf-commandlineparseriSazonov/PowerShell:perf-commandlineparserCopy head branch name to clipboard
daxian-dbw merged 1 commit into
PowerShell:masterPowerShell/PowerShell:masterfrom
iSazonov:perf-commandlineparseriSazonov/PowerShell:perf-commandlineparserCopy head branch name to clipboard
Conversation
daxian-dbw
approved these changes
Dec 2, 2020
15 tasks
|
🎉 Handy links: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Like #14298 the PR postpones ICU initialization at startup. Perf win ~20-27 ms.
Before:
After:
PR Context
Related #14268
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.