Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Use StringComparison.Ordinal insted of StringComparison.CurrentCulture at startup time#14298

Merged
daxian-dbw merged 1 commit into
PowerShell:masterPowerShell/PowerShell:masterfrom
iSazonov:perf-startwithiSazonov/PowerShell:perf-startwithCopy head branch name to clipboard
Dec 2, 2020
Merged

Use StringComparison.Ordinal insted of StringComparison.CurrentCulture at startup time#14298
daxian-dbw merged 1 commit into
PowerShell:masterPowerShell/PowerShell:masterfrom
iSazonov:perf-startwithiSazonov/PowerShell:perf-startwithCopy head branch name to clipboard

Conversation

@iSazonov

@iSazonov iSazonov commented Dec 1, 2020

Copy link
Copy Markdown
Collaborator

PR Summary

Use StringComparison.Ordinal instead of default StringComparison.CurrentCulture.

This looks like a bug but discovered in startup scenario perf analyze - perf win 0.7% (5 ms - so long because of ICU initialization).

PR Context

Related #14268

PR Checklist

@iSazonov iSazonov added the CL-Performance Indicates that a PR should be marked as a performance improvement in the Change Log label Dec 1, 2020
@iSazonov iSazonov requested a review from SteveL-MSFT December 1, 2020 06:05
@iSazonov iSazonov closed this Dec 2, 2020
@iSazonov iSazonov reopened this Dec 2, 2020
@iSazonov

iSazonov commented Dec 2, 2020

Copy link
Copy Markdown
Collaborator Author

Reopen to restart CIs.

@daxian-dbw daxian-dbw merged commit 548e939 into PowerShell:master Dec 2, 2020
@iSazonov iSazonov added this to the 7.2.0-preview.2 milestone Dec 3, 2020
@iSazonov iSazonov deleted the perf-startwith branch December 3, 2020 02:58
@ghost

ghost commented Dec 15, 2020

Copy link
Copy Markdown

🎉v7.2.0-preview.2 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-Performance Indicates that a PR should be marked as a performance improvement in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.