Turn on `/features:strict` for all projects by xtqqczze · Pull Request #13383 · PowerShell/PowerShell

xtqqczze · Aug 8, 2020

PR Summary

Follow-up: #13285

For example, with strict mode enabled, the following is an error:

IntPtr ptr = IntPtr.Zero;
if (ptr == null) // Warning CS8073 The result of the expression is always 'false' since a value of type 'IntPtr' is never equal to 'null' of type 'IntPtr?'

PR Context

PR Checklist

PR has a meaningful title
- Use the present tense and imperative mood when describing your changes
Summarized changes
Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
This PR is ready to merge and is not Work in Progress.
- If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.
Breaking changes
- None
- OR
- [NA] Experimental feature(s) needed
  - [NA] Experimental feature name(s):
User-facing changes
- Not Applicable
- OR
- [NA] Documentation needed
  - [NA] Issue filed:
Testing - New and feature
- N/A or can only be tested interactively
- OR
- [NA] Make sure you've added a new test if existing tests do not effectively test the code changed
Tooling
- I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
- OR
- [NA] I have considered the user experience from a tooling perspective and enumerated concerns in the summary. This may include:
  - Impact on PowerShell Editor Services which is used in the PowerShell extension for VSCode (which runs in a different PS Host).
  - Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features.
  - Impact on PSScriptAnalyzer (which provides linting & formatting in the editor extensions).
  - Impact on EditorSyntax (which provides syntax highlighting with in VSCode, GitHub, and many other editors).

ghost · Aug 19, 2020

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

TravisEz13 · Aug 19, 2020

I recommend that the maintainers review if we want this setting.

ghost · Aug 27, 2020

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

daxian-dbw · Sep 1, 2020

@PowerShell/powershell-maintainers reviewed this PR and agreed to accept it, but the changes should be made in powershell.common.props instead.

xtqqczze · Sep 5, 2020

@daxian-dbw powershell.common.props is not included in all projects, e.g. xUnit.test Using Directory.Build.props propgates the property to any existing or new projects in repository.

TravisEz13 · Sep 9, 2020

add it to xUnit separately if you want it there.

ghost · Sep 17, 2020

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

ghost · Oct 17, 2020

This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 15 days. It will be closed if no further activity occurs within 10 days of this comment.

ghost · Nov 17, 2020

🎉v7.2.0-preview.1 has been released which incorporates this pull request.:tada:

Handy links:

Release Notes

ghost assigned TravisEz13 Aug 8, 2020

xtqqczze force-pushed the features-strict branch 2 times, most recently from 07df421 to 86ff7da Compare August 8, 2020 23:52

xtqqczze changed the title ~~WIP: Use C# strict mode~~ Use C# strict mode Aug 9, 2020

xtqqczze marked this pull request as ready for review August 9, 2020 22:57

xtqqczze requested review from TravisEz13, adityapatwardhan, anmenaga and daxian-dbw as code owners August 9, 2020 22:57

xtqqczze marked this pull request as draft August 9, 2020 22:57

xtqqczze force-pushed the features-strict branch from 86ff7da to ff1c0b5 Compare August 10, 2020 23:10

xtqqczze marked this pull request as ready for review August 10, 2020 23:11

ghost added the Review - Needed The PR is being reviewed label Aug 19, 2020

TravisEz13 added Review - Maintainer The PR/issue needs a review from the PowerShell repo Maintainers and removed Review - Needed The PR is being reviewed labels Aug 19, 2020

ghost added the Review - Needed The PR is being reviewed label Aug 27, 2020

ghost removed the Review - Needed The PR is being reviewed label Sep 1, 2020

daxian-dbw removed the Review - Maintainer The PR/issue needs a review from the PowerShell repo Maintainers label Sep 1, 2020

ghost added the Review - Needed The PR is being reviewed label Sep 17, 2020

TravisEz13 added Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept and removed Review - Needed The PR is being reviewed labels Oct 2, 2020

ghost added the Stale label Oct 17, 2020

xtqqczze changed the title ~~Use C# strict mode~~ Turn on /features:strict for all projects Oct 22, 2020

ghost removed Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept Stale labels Oct 22, 2020

Turn on /features:strict for all projects

a43a286

xtqqczze force-pushed the features-strict branch from ff1c0b5 to a43a286 Compare October 22, 2020 13:25

TravisEz13 approved these changes Oct 23, 2020

View reviewed changes

TravisEz13 changed the title ~~Turn on /features:strict for all projects~~ Turn on /features:strict for all projects Oct 23, 2020

TravisEz13 merged commit ebff402 into PowerShell:master Oct 23, 2020

TravisEz13 added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Oct 23, 2020

TravisEz13 added this to the 7.2.0-preview.1 milestone Oct 23, 2020

xtqqczze deleted the features-strict branch October 23, 2020 19:35

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Turn on `/features:strict` for all projects#13383

Turn on `/features:strict` for all projects#13383
TravisEz13 merged 1 commit into
PowerShell:masterPowerShell/PowerShell:masterfrom
xtqqczze:features-strictxtqqczze/PowerShell-PowerShell:features-strictCopy head branch name to clipboard

xtqqczze commented Aug 8, 2020 •

edited

Loading

Uh oh!

ghost commented Aug 19, 2020

Uh oh!

TravisEz13 commented Aug 19, 2020

Uh oh!

ghost commented Aug 27, 2020

Uh oh!

daxian-dbw commented Sep 1, 2020

Uh oh!

xtqqczze commented Sep 5, 2020

Uh oh!

TravisEz13 commented Sep 9, 2020

Uh oh!

ghost commented Sep 17, 2020

Uh oh!

ghost commented Oct 17, 2020

Uh oh!

ghost commented Nov 17, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Search code, repositories, users, issues, pull requests...

Conversation

xtqqczze commented Aug 8, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Summary

PR Context

PR Checklist

Uh oh!

ghost commented Aug 19, 2020

Uh oh!

TravisEz13 commented Aug 19, 2020

Uh oh!

ghost commented Aug 27, 2020

Uh oh!

daxian-dbw commented Sep 1, 2020

Uh oh!

xtqqczze commented Sep 5, 2020

Uh oh!

TravisEz13 commented Sep 9, 2020

Uh oh!

ghost commented Sep 17, 2020

Uh oh!

ghost commented Oct 17, 2020

Uh oh!

ghost commented Nov 17, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

xtqqczze commented Aug 8, 2020 •

edited

Loading