Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Fix comparison of value type object to null#13285

Merged
anmenaga merged 3 commits into
PowerShell:masterPowerShell/PowerShell:masterfrom
xtqqczze:RCS1166xtqqczze/PowerShell-PowerShell:RCS1166Copy head branch name to clipboard
Aug 10, 2020
Merged

Fix comparison of value type object to null#13285
anmenaga merged 3 commits into
PowerShell:masterPowerShell/PowerShell:masterfrom
xtqqczze:RCS1166xtqqczze/PowerShell-PowerShell:RCS1166Copy head branch name to clipboard

Conversation

@xtqqczze

@xtqqczze xtqqczze commented Jul 27, 2020

Copy link
Copy Markdown
Contributor

PR Summary

  • Fix comparison of value type object to null

PR Context

#13286

PR Checklist

@ghost ghost assigned anmenaga Jul 27, 2020
@xtqqczze xtqqczze mentioned this pull request Jul 27, 2020
14 tasks
@ghost ghost added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Jul 30, 2020
@xtqqczze xtqqczze mentioned this pull request Jul 30, 2020
14 tasks
@xtqqczze xtqqczze marked this pull request as ready for review July 30, 2020 21:16
@ghost ghost removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Jul 30, 2020
@xtqqczze xtqqczze changed the title Autofix RCS1166: Value type object is never equal to null Fix RCS1166: Value type object is never equal to null Jul 30, 2020

@daxian-dbw daxian-dbw left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one comment

Comment thread src/Microsoft.PowerShell.ConsoleHost/host/msh/ConsoleHost.cs Outdated
@xtqqczze xtqqczze changed the title Fix RCS1166: Value type object is never equal to null Fix comparison of value type object to null Jul 31, 2020
@xtqqczze

Copy link
Copy Markdown
Contributor Author

rebased to restart CI

@ghost ghost added the Review - Needed The PR is being reviewed label Aug 8, 2020
@ghost

ghost commented Aug 8, 2020

Copy link
Copy Markdown

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@xtqqczze

xtqqczze commented Aug 8, 2020

Copy link
Copy Markdown
Contributor Author

rebased to pass CI

@anmenaga anmenaga merged commit d8f8f0a into PowerShell:master Aug 10, 2020
@ghost ghost removed the Review - Needed The PR is being reviewed label Aug 10, 2020
@anmenaga anmenaga added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Aug 10, 2020
@xtqqczze xtqqczze deleted the RCS1166 branch August 10, 2020 23:08
@ghost

ghost commented Aug 17, 2020

Copy link
Copy Markdown

🎉v7.1.0-preview.6 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.