Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Revert "Add action to label size of PR"#13325

Merged
TravisEz13 merged 1 commit into
masterPowerShell/PowerShell:masterfrom
revert-13321-TravisEz13-patch-2PowerShell/PowerShell:revert-13321-TravisEz13-patch-2Copy head branch name to clipboard
Jul 31, 2020
Merged

Revert "Add action to label size of PR"#13325
TravisEz13 merged 1 commit into
masterPowerShell/PowerShell:masterfrom
revert-13321-TravisEz13-patch-2PowerShell/PowerShell:revert-13321-TravisEz13-patch-2Copy head branch name to clipboard

Conversation

@rjmholt

@rjmholt rjmholt commented Jul 31, 2020

Copy link
Copy Markdown
Collaborator

Reverts #13321

The GitHub action is currently failing in new PRs, so we need more configuration to make it work properly it seems.

@vexx32

vexx32 commented Jul 31, 2020

Copy link
Copy Markdown
Collaborator

@SteveL-MSFT is this functionality something PoshChan could handle?

@rjmholt rjmholt added the CL-NotInBuild Indicates that a PR is reverted and not part of the build. label Jul 31, 2020
@daxian-dbw

Copy link
Copy Markdown
Member

@TravisEz13 Shall we merge this one sooner?

@TravisEz13

Copy link
Copy Markdown
Member

Can we give an example of where it's failing?

@TravisEz13

TravisEz13 commented Jul 31, 2020

Copy link
Copy Markdown
Member

https://github.com/PowerShell/PowerShell/runs/932788471?check_suite_focus=true

looks like its rate limited (even with auth). We can filter the events to reduce the load.

GitHub
PowerShell for every system! Contribute to PowerShell/PowerShell development by creating an account on GitHub.

@TravisEz13

Copy link
Copy Markdown
Member

This should help with the problem

@vexx32

vexx32 commented Jul 31, 2020

Copy link
Copy Markdown
Collaborator

That output doesn't read to me as being rate-limited:

{ RequestError [HttpError]: Resource not accessible by integration
    at response.text.then.message (/usr/local/share/.config/yarn/global/node_modules/@octokit/request/dist-node/index.js:66:23)
    at processTicksAndRejections (internal/process/task_queues.js:86:5)
...
     'x-ratelimit-limit': '15000',
     'x-ratelimit-remaining': '14998',
     'x-ratelimit-reset': '1596216976',

Plenty of attempts remaining, and that error doesn't look like "try again later" it reads more "access denied" to me.

@TravisEz13 TravisEz13 merged commit 5abcd58 into master Jul 31, 2020
@TravisEz13 TravisEz13 deleted the revert-13321-TravisEz13-patch-2 branch July 31, 2020 18:06
TravisEz13 added a commit that referenced this pull request Aug 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-NotInBuild Indicates that a PR is reverted and not part of the build.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.