Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Add action to label size of PR#13321

Merged
daxian-dbw merged 2 commits into
masterPowerShell/PowerShell:masterfrom
TravisEz13-patch-2PowerShell/PowerShell:TravisEz13-patch-2Copy head branch name to clipboard
Jul 30, 2020
Merged

Add action to label size of PR#13321
daxian-dbw merged 2 commits into
masterPowerShell/PowerShell:masterfrom
TravisEz13-patch-2PowerShell/PowerShell:TravisEz13-patch-2Copy head branch name to clipboard

Conversation

@TravisEz13

@TravisEz13 TravisEz13 commented Jul 30, 2020

Copy link
Copy Markdown
Member

PR Summary

Add action to label size of PR

PR Context

Add framework for requiring additional approval for large PRs

PR Checklist

@adityapatwardhan

Copy link
Copy Markdown
Member

We should add files.wxs in the ignore list. Are there any other "generated" files we should ignore?

@daxian-dbw daxian-dbw mentioned this pull request Jul 30, 2020
14 tasks
Comment thread .github/workflows/size-label.yml
@rjmholt

rjmholt commented Jul 30, 2020

Copy link
Copy Markdown
Collaborator

github-actions bot added the size/S label 1 hour ago

Cool!

@daxian-dbw daxian-dbw merged commit 2398185 into master Jul 30, 2020
@daxian-dbw daxian-dbw deleted the TravisEz13-patch-2 branch July 30, 2020 23:49
@daxian-dbw daxian-dbw added the CL-NotInBuild Indicates that a PR is reverted and not part of the build. label Jul 30, 2020
@daxian-dbw daxian-dbw added this to the 7.1.0-preview.7 milestone Jul 30, 2020
@rjmholt

rjmholt commented Jul 31, 2020

Copy link
Copy Markdown
Collaborator

The labelling task seems to have failed in new PRs...

@xtqqczze

Copy link
Copy Markdown
Contributor

This should only apply to PowerShell/PowerShell and not to forks!

image

@xtqqczze

xtqqczze commented Jul 31, 2020

Copy link
Copy Markdown
Contributor

Github action repo is https://github.com/pascalgn/size-label-action

GitHub
GitHub action to assign labels based on pull request change sizes - pascalgn/size-label-action

@xtqqczze

Copy link
Copy Markdown
Contributor

The labelling task seems to have failed in new PRs...

It seems the Github action does not work for PRs with branches from forks (pascalgn/size-label-action#10)

rjmholt added a commit that referenced this pull request Jul 31, 2020
@TravisEz13 TravisEz13 modified the milestones: 7.1.0-preview.7, 7.1.0-preview.6 Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-NotInBuild Indicates that a PR is reverted and not part of the build. size/S

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.