Remove class SingletonFamily and MF attribute id
#192
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 27, 2023
Merged
Member
Author
This was referenced Dec 4, 2023
Merged
476e8d0 to
1c029a0
Compare
583384f to
b4ab6e1
Compare
1c029a0 to
66dd7ac
Compare
b4ab6e1 to
5ad51fe
Compare
This was referenced Dec 11, 2023
gcroci2
reviewed
Dec 13, 2023
gcroci2
reviewed
Dec 13, 2023
gcroci2
reviewed
Dec 13, 2023
gcroci2
reviewed
Dec 13, 2023
gcroci2
approved these changes
Dec 13, 2023
66dd7ac to
79ec809
Compare
5ad51fe to
a0d5ea7
Compare
79ec809 to
7894c6d
Compare
fa32a02 to
fc2f8d5
Compare
Member
Author
Merge activity
|
7894c6d to
efe2148
Compare
Class MolecularFamily can be used to represent singleton molecular family.
We let the loaders like `GNPSMolecularFamilyLoader` to decide how to assign family id to singleton MFs.
Co-authored-by: Giulia Crocioni <55382553+gcroci2@users.noreply.github.com>
Co-authored-by: Giulia Crocioni <55382553+gcroci2@users.noreply.github.com>
fc2f8d5 to
70a61b5
Compare
This was referenced Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Singleton molecular families can be well represented with the class
MolecularFamily, and it's not needed to keep a specific classSingletonFamilyfor them, so this PR removed it.As for the family id, the class
SingleFamilyautomatically set it (i.e."singleton-" + uuid), while the classMolecularFamilyrequires users to provide the family id during initiation. It makes more sense to let users or loaders of molecular family to decide how to set family id. So in theGNPSMolecularFamilyLoaderclass, the name of singleton MF was updated to"singleton-" + spectrum_id.The attribute
idof MolecularFamily is unused by anywhere, so it's removed too.