Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

return list for get_bgcs methods of BGC loaders #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
CunliangGeng merged 3 commits into from
Dec 14, 2023
Merged

return list for get_bgcs methods of BGC loaders #182

CunliangGeng merged 3 commits into from
Dec 14, 2023

Conversation

@CunliangGeng
Copy link
Member

@CunliangGeng CunliangGeng commented Nov 20, 2023

This PR changed the returned value of get_bgcs methods in BGC loaders from dict to list, making sure that methods get_bgcs and get_gcfs have consistent returned type.

@CunliangGeng CunliangGeng mentioned this pull request Nov 20, 2023
Merged
@CunliangGeng Graphite App
Copy link
Member Author

CunliangGeng commented Nov 20, 2023 •
edited
Loading

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@CunliangGeng CunliangGeng mentioned this pull request Nov 20, 2023
Merged
@CunliangGeng CunliangGeng requested a review from gcroci2 November 20, 2023 09:14
This was referenced Nov 20, 2023
Closed
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
This was referenced Nov 27, 2023
Merged
Merged
Merged
Merged
@CunliangGeng CunliangGeng mentioned this pull request Dec 5, 2023
Closed
@CunliangGeng CunliangGeng force-pushed the 11-15-filter_singleton_gcf branch from 5139465 to b60b24c Compare December 11, 2023 13:03
This was referenced Dec 11, 2023
Merged
Merged
Merged
Merged
Merged
@CunliangGeng CunliangGeng force-pushed the 11-15-filter_singleton_gcf branch from b60b24c to 1324ba4 Compare December 14, 2023 10:39
Base automatically changed from 11-15-filter_singleton_gcf to dev December 14, 2023 10:42
@CunliangGeng
change the returned type of MibigLoader.get_bgcs
18a3e0c 
- change returned value from dict to list for `MibigLoader.get_bgcs` method and the underlying method `._parse_bgcs`
- update the use of the changed methods
- update unit tests
@CunliangGeng
change the returned type of AntismashBGCLoader.get_bgcs
5865b57 
- change returned value from dict to list for `AntismashBGCLoader.get_bgcs` method and the underlying method `._parse_bgcs`
- update the use of the changed methods
- update unit tests
@CunliangGeng Graphite App
Copy link
Member Author

CunliangGeng commented Dec 14, 2023 •
edited
Loading

Merge activity

@CunliangGeng CunliangGeng merged commit e6b758a into dev Dec 14, 2023
@CunliangGeng CunliangGeng deleted the 11-17-update_get_bgcs branch December 14, 2023 10:45
This was referenced Dec 20, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gcroci2 gcroci2 gcroci2 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@CunliangGeng @gcroci2
Morty Proxy This is a proxified and sanitized view of the page, visit original site.