-
Notifications
You must be signed in to change notification settings - Fork 13
Enable filtering of singleton molecular families #191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 27, 2023
Merged
Member
Author
This was referenced Dec 4, 2023
Merged
0ea4383 to
1e237aa
Compare
476e8d0 to
1c029a0
Compare
1e237aa to
9e5f322
Compare
1c029a0 to
66dd7ac
Compare
This was referenced Dec 11, 2023
gcroci2
approved these changes
Dec 13, 2023
9e5f322 to
ff3f31e
Compare
66dd7ac to
79ec809
Compare
ff3f31e to
9163671
Compare
79ec809 to
7894c6d
Compare
Member
Author
Merge activity
|
- change property to method - rename `families` to `get_mfs`
7894c6d to
efe2148
Compare
This was referenced Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to PR #181, this PR adds a new parameter
keep_singletonin the methodget_mfsof MolecularFamily loader.Major changes:
familiesto methodget_mfskeep_singletonto methodget_mfs