Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit 2c956af

Browse filesBrowse files
mhegazymhegazy
authored
Merge pull request microsoft#23664 from a-tarasyuk/feature/strictPropertyInitialization-can-not-be-used-without-strictNullChecks
Add warn that user can not use --strictPropertyInitialization without --strictNullChecks
2 parents 83bc70d + f04a18a commit 2c956af
Copy full SHA for 2c956af

6 files changed

+28Lines changed: 28 additions & 0 deletions
Expand file treeCollapse file tree
Open diff view settings
Collapse file

‎src/compiler/program.ts‎

Copy file name to clipboardExpand all lines: src/compiler/program.ts
+4Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2062,6 +2062,10 @@ namespace ts {
20622062
}
20632063

20642064
function verifyCompilerOptions() {
2065+
if (options.strictPropertyInitialization && !options.strictNullChecks) {
2066+
createDiagnosticForOptionName(Diagnostics.Option_0_cannot_be_specified_without_specifying_option_1, "strictPropertyInitialization", "strictNullChecks");
2067+
}
2068+
20652069
if (options.isolatedModules) {
20662070
if (options.declaration) {
20672071
createDiagnosticForOptionName(Diagnostics.Option_0_cannot_be_specified_with_option_1, "declaration", "isolatedModules");
Collapse file

‎tests/baselines/reference/optionsStrictPropertyInitializationStrictNullChecks.errors.txt‎

Copy file name to clipboard
+7Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
error TS5052: Option 'strictPropertyInitialization' cannot be specified without specifying option 'strictNullChecks'.
2+
3+
4+
!!! error TS5052: Option 'strictPropertyInitialization' cannot be specified without specifying option 'strictNullChecks'.
5+
==== tests/cases/compiler/optionsStrictPropertyInitializationStrictNullChecks.ts (0 errors) ====
6+
var x;
7+
Collapse file

‎tests/baselines/reference/optionsStrictPropertyInitializationStrictNullChecks.js‎

Copy file name to clipboard
+6Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
//// [optionsStrictPropertyInitializationStrictNullChecks.ts]
2+
var x;
3+
4+
5+
//// [optionsStrictPropertyInitializationStrictNullChecks.js]
6+
var x;
Collapse file

‎tests/baselines/reference/optionsStrictPropertyInitializationStrictNullChecks.symbols‎

Copy file name to clipboard
+4Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
=== tests/cases/compiler/optionsStrictPropertyInitializationStrictNullChecks.ts ===
2+
var x;
3+
>x : Symbol(x, Decl(optionsStrictPropertyInitializationStrictNullChecks.ts, 0, 3))
4+
Collapse file

‎tests/baselines/reference/optionsStrictPropertyInitializationStrictNullChecks.types‎

Copy file name to clipboard
+4Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
=== tests/cases/compiler/optionsStrictPropertyInitializationStrictNullChecks.ts ===
2+
var x;
3+
>x : any
4+
Collapse file

‎tests/cases/compiler/optionsStrictPropertyInitializationStrictNullChecks.ts‎

Copy file name to clipboard
+3Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
// @strictPropertyInitialization: true
2+
3+
var x;

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.