Add warn that user can not use --strictPropertyInitialization without --strictNullChecks#23664
Merged
mhegazy merged 2 commits intoApr 30, 2018
microsoft:mastermicrosoft/TypeScript:masterfrom
a-tarasyuk:feature/strictPropertyInitialization-can-not-be-used-without-strictNullChecksa-tarasyuk/TypeScript:feature/strictPropertyInitialization-can-not-be-used-without-strictNullChecksCopy head branch name to clipboard
Merged
Add warn that user can not use --strictPropertyInitialization without --strictNullChecks#23664mhegazy merged 2 commits intomicrosoft:mastermicrosoft/TypeScript:masterfrom a-tarasyuk:feature/strictPropertyInitialization-can-not-be-used-without-strictNullChecksa-tarasyuk/TypeScript:feature/strictPropertyInitialization-can-not-be-used-without-strictNullChecksCopy head branch name to clipboard
mhegazy merged 2 commits into
microsoft:mastermicrosoft/TypeScript:masterfrom
a-tarasyuk:feature/strictPropertyInitialization-can-not-be-used-without-strictNullChecksa-tarasyuk/TypeScript:feature/strictPropertyInitialization-can-not-be-used-without-strictNullChecksCopy head branch name to clipboard
Conversation
… --strictNullChecks
Contributor
|
thanks @a-tarasyuk. we also need a test to go with this change. see |
mhegazy
reviewed
Apr 26, 2018
| @@ -0,0 +1,70 @@ | ||
| // @strictPropertyInitialization: true | ||
| // @strictNullChecks: true |
Contributor
There was a problem hiding this comment.
sorry i was not clear. i meant a test for the new error message.. i.e.
// @strictPropertyInitialization: true
// @strictNullChecks: false
var x;b143af3 to
f04a18a
Compare
Contributor
|
thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes part of #23659