Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Comments

Close side panel

Fix String type with byte format#25

Merged
kean merged 1 commit intoCreateAPI:mainCreateAPI/CreateAPI:mainfrom
mattia:hotfix/string-byte-representationCopy head branch name to clipboard
Feb 17, 2022
Merged

Fix String type with byte format#25
kean merged 1 commit intoCreateAPI:mainCreateAPI/CreateAPI:mainfrom
mattia:hotfix/string-byte-representationCopy head branch name to clipboard

Conversation

@mattia
Copy link
Contributor

@mattia mattia commented Feb 17, 2022

When the spec defines a string property with a byte format at the moment a String property is generated, but a Data property should be generated instead.

With input:

test_property:
  type: string
  format: byte

Before:

var testProperty: String

After:

var testProperty: Data

@kean kean merged commit c6aad2c into CreateAPI:main Feb 17, 2022
@kean
Copy link
Member

kean commented Feb 17, 2022

Thanks for making the change! I appreciate it.

@mattia
Copy link
Contributor Author

mattia commented Feb 17, 2022

Thank you for the library!

@mattia mattia deleted the hotfix/string-byte-representation branch February 17, 2022 20:16
@imjn imjn mentioned this pull request Mar 9, 2022
Merged
@simorgh3196 simorgh3196 mentioned this pull request Mar 15, 2022
Closed
@liamnichols liamnichols mentioned this pull request Jun 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mattia @kean
Morty Proxy This is a proxified and sanitized view of the page, visit original site.