Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Comments

Close side panel

Revert "Fix String type with byte format"#41

Closed
liamnichols wants to merge 1 commit intomainCreateAPI/CreateAPI:mainfrom
revert-25-hotfix/string-byte-representationCreateAPI/CreateAPI:revert-25-hotfix/string-byte-representationCopy head branch name to clipboard
Closed

Revert "Fix String type with byte format"#41
liamnichols wants to merge 1 commit intomainCreateAPI/CreateAPI:mainfrom
revert-25-hotfix/string-byte-representationCreateAPI/CreateAPI:revert-25-hotfix/string-byte-representationCopy head branch name to clipboard

Conversation

@liamnichols
Copy link
Member

@liamnichols liamnichols commented Jun 10, 2022

Reverts #25
Closes #29

According to the Swagger documentation, they are defined as Base64-encoded characters.
So it would be correct to treat it as a String, wouldn't it?

https://swagger.io/docs/specification/data-models/data-types/#format

An optional format modifier serves as a hint at the contents and format of the string. OpenAPI defines the following built-in string formats:
...
byte – base64-encoded characters, for example, U3dhZ2dlciByb2Nrcw==

cc @simorgh3196, @mattia

@liamnichols
Copy link
Member Author

liamnichols commented Jun 10, 2022

Actually, I don't think that this needs reverting. I'll share some notes in the issue.

@liamnichols liamnichols deleted the revert-25-hotfix/string-byte-representation branch August 13, 2022 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Is Data the correct type for properties with the format: byte modifier?

1 participant

@liamnichols
Morty Proxy This is a proxified and sanitized view of the page, visit original site.