Fixed test failures for string with byte format#26
Merged
kean merged 1 commit intoCreateAPI:mainCreateAPI/CreateAPI:mainfrom Mar 14, 2022
Merged
Fixed test failures for string with byte format#26kean merged 1 commit intoCreateAPI:mainCreateAPI/CreateAPI:mainfrom
kean merged 1 commit intoCreateAPI:mainCreateAPI/CreateAPI:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Made changes in tests for #25
Tests still fail after this PR but they are because of other issues.
I think other failures are caused by this change.
@kean Do you have any ideas?Sorry it was clear and simple. 😄 Fixed in #28