Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Comments

Close side panel

TPC: Add task for receiving TPCTrackingQA from external#545

Merged
Barthelemy merged 1 commit intoAliceO2Group:masterAliceO2Group/QualityControl:masterfrom
davidrohr:master_pull_requestdavidrohr/QualityControl:master_pull_requestCopy head branch name to clipboard
Nov 12, 2020
Merged

TPC: Add task for receiving TPCTrackingQA from external#545
Barthelemy merged 1 commit intoAliceO2Group:masterAliceO2Group/QualityControl:masterfrom
davidrohr:master_pull_requestdavidrohr/QualityControl:master_pull_requestCopy head branch name to clipboard

Conversation

@davidrohr
Copy link
Contributor

This adds the TPC JSON configuration to receive TPC Tracking QA data as external input.
The second variant to process the QA in a real QC task will come in a second PR.

@davidrohr
Copy link
Contributor Author

@Barthelemy : Following up on the e-mail thread: I have truncated and filled qcg-test.cern.ch with this PR and AliceO2Group/AliceO2#4810, looks good.
Perhaps we can just address 1 point before merging:

  • I have to use External-1 in the query "query": "External-1:TPC/TRACKINGQA/0", otherwise it does not work. Any idea why?
    I think anything else is OK for now and can be improved later.

@Barthelemy
Copy link
Collaborator

@davidrohr That must be a bug. I can have a look this afternoon.

@davidrohr
Copy link
Contributor Author

@Barthelemy : In fact what I wrote is wrong, I can change the name, just had to do it in 2 places, which I didn't see before :)
After I have renamed the external task it works. Perhaps one could still improve the error message :)
From my side this is ready to be merged.

@Barthelemy
Copy link
Collaborator

Ok, good to know, I was indeed not able to reproduce it. I am approving, and later merging. I will see what I can do for the error message.

@Barthelemy
Copy link
Collaborator

@TimoWilken It seems that build/QualityControl/o2 has been building for almost a day ? would you mind checking it ?

@TimoWilken
Copy link
Contributor

@Barthelemy I'll have a look!

@Barthelemy Barthelemy merged commit 97afd72 into AliceO2Group:master Nov 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.