Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Comments

Close side panel

Add option to push TCanvases with full layout to QC instead of individual histograms for TPC Tracking QA#4818

Merged
davidrohr merged 6 commits intoAliceO2Group:devAliceO2Group/AliceO2:devfrom
davidrohr:dev_pull_request2davidrohr/AliceO2:dev_pull_request2Copy head branch name to clipboard
Nov 13, 2020
Merged

Add option to push TCanvases with full layout to QC instead of individual histograms for TPC Tracking QA#4818
davidrohr merged 6 commits intoAliceO2Group:devAliceO2Group/AliceO2:devfrom
davidrohr:dev_pull_request2davidrohr/AliceO2:dev_pull_request2Copy head branch name to clipboard

Conversation

@davidrohr
Copy link
Collaborator

@davidrohr davidrohr commented Nov 11, 2020

Added the option discussed in #4810 (setting is GPU_QA.shipToQCAsCanvas). In order to run (needs AliceO2Group/QualityControl#545)

o2-tpc-reco-workflow --infile tpcdigits.root --output-type clusters,tracks,qa --configKeyValues "GPU_QA.shipToQCAsCanvas=true" | o2-qc --config json:/${QUALITYCONTROL_ROOT}/etc/tpcQCTrackingFromExternal_direct.json

Nice that this worked more or less out of the box, at least without any change on the QC side. Biggest problem was actually ROOT object ownership which took me some hours to get right and avoid all crashes / memory corruption... Still not 100% sure but I checked it with valgrind and address sanitizer and it seems ok.

You can check the results here: https://qcg-test.cern.ch/?page=objectTree under TPC/MO/TPCTrackingQA. It contains the individual histograms as before, and the full layouts, which are called ceff_* cres_* cpull_*.
It seems to work correctly except for the colors. Will have to see what I can do there, I guess the problem is that I am assigning some colors defined locally, perhaps I can change that to some default ROOT colors. And obviously the Canvas names still need to be cleaned up.

@davidrohr
Copy link
Collaborator Author

davidrohr commented Nov 12, 2020

@wiechula @tklemenz @stheckel : ping, new version with proper layouts

@davidrohr davidrohr changed the title [WIP] Add option to push TCanvases with full layout to QC instead of individual histograms for TPC Tracking QA Add option to push TCanvases with full layout to QC instead of individual histograms for TPC Tracking QA Nov 12, 2020
@davidrohr
Copy link
Collaborator Author

davidrohr commented Nov 12, 2020

OK, using default ROOT colors, the histograms look OK, also made sure all objects have proper names and did some clean up. I think this can be merged for now.
I updated the qcg test website: the new canvas objects are all prefixed with _layout. Only problem I see is that the legend in the Canvas looses the colors of the histograms, but frankly I have no idea how to fix that. Perhaps someone with more ROOT knowledge should give it a try.

wiechula
wiechula approved these changes Nov 12, 2020
View reviewed changes
Copy link
Collaborator

@wiechula wiechula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @davidrohr , very nice. I think this looks perfect.

@davidrohr
Copy link
Collaborator Author

davidrohr commented Nov 12, 2020

@TimoWilken @ktf : The build/O2/o2 CI is marked as failed but there is no build log. Could you check?

@TimoWilken
Copy link
Contributor

TimoWilken commented Nov 12, 2020

@davidrohr Looking into it!

@TimoWilken
Copy link
Contributor

TimoWilken commented Nov 12, 2020

@davidrohr Seems to be the same problem as #4824. I'll rerun the build and see if I can get a useful error message.

Building O2@4818
ERROR: Error while executing .../o2/sw/SPECS/slc7_x86-64/O2/4818-1/build.sh on `alibuild08.cern.ch'.
ERROR: Log can be found in .../o2/sw/BUILD/O2-latest-4818/log
ERROR: Please upload it to CERNBox/Dropbox if you intend to request support.
ERROR: Build directory is .../o2/sw/BUILD/O2-latest-4818/O2.
ERROR: 
ERROR: Note that you have packages in development mode.
ERROR: Devel sources are not updated automatically, you must do it by hand.
ERROR: This problem might be due to one or more outdated devel sources.
ERROR: To update all development packages required for this build it is usually sufficient to do:
ERROR: 
ERROR:   ( cd O2 && git pull --rebase )

@davidrohr davidrohr merged commit 3325211 into AliceO2Group:dev Nov 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wiechula wiechula wiechula approved these changes

@shahor02 shahor02 Awaiting requested review from shahor02 shahor02 is a code owner

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@davidrohr @TimoWilken @wiechula
Morty Proxy This is a proxified and sanitized view of the page, visit original site.