Provide TPC Tracking QA to QC (Part 1)#4810
Provide TPC Tracking QA to QC (Part 1)#4810davidrohr merged 6 commits intoAliceO2Group:devAliceO2Group/AliceO2:devfrom
Conversation
wiechula
left a comment
There was a problem hiding this comment.
Hi @davidrohr , looks good. That was quick action! I guess the details we can then discuss. These are quite many histograms, so I think we will need to see how to deal with this in a good way. Most probably we simply can define a couple Layouts combining the relevant plots.
|
@wiechula : Note that ~50% of what I uploaded will not be there finally, the website currently contains also some bogus intermediate histograms. For myself, I am usually already arranging them in canvases, see the plots in this file: I am not sure if QC can work with canvases, if yes I could perhaps already provide them in this way. |
|
@TimoWilken : I just saw that the macOS see doesn't use the new nice HTML log feature. Is there a reason for this, or can this be changed? :) |
|
@davidrohr: that should change soon! :) |
…simple shipping of histograms
…ut writing them to file
…ng as external to QC
97ae2bb to
f2f234b
Compare
You can publish any TObject. |
|
But will QCG correctly display a canvas with multiple plots? |
|
I have no idea about the canvas, it was just an idea, since I have them anyway to create PDFs directly. |
|
https://alice.its.cern.ch/jira/browse/QC-482 |
OK, sure, I can just give it a try and let's see what happens :) |
|
@Barthelemy : For reference, it seems to work, the test object I pushed to the TPCTrackingQA folder is a TCanvas and it seems to show the contained histogram correctly. Currently trying with some more complicated Canvas, but I am having some issue with ROOT ownership, let's see. |
|
@davidrohr Nice ! I see them. I am not surprised that ROOT ownership comes in the way. FYI the objects you publish are owned by you, so the QC framework will not try to delete them behind your back. |
This PR contains some preparation and goes the easy way to ship the QA histograms that can optionally be created during the tracking to QC.
The current output can be seen on https://qcg-test.cern.ch/?page=objectTree under TPC/MO/External-1 (There are some old intermediate histograms from 22:07 today pushed there accidentaly, no idea how to remove them, please ignore them). Secondaries and z-resolution is currently broken / missing, but independently from the export to QC.
In order to run: (Needs AliceO2Group/QualityControl#545)
(this will write to the test ccdb and overwrite what I just pushed there)
This PR already separates the extraction of the statistics and the postprocessing into individual steps.
However, currently they are just executed both one after another when the histograms are created. This can be changed easily later on to have a full chain with parallel aggregation -> merging -> postprocessing. Will not need any change in the TPC QA code, just in the DPL / QC / routing part.
In a second step, I'll provide a separate QC task, which will be able to run the resolution and the efficiency QA using the qc-tpc-track-reader as input, but this requires some more work. But it will basically provide a subset of what is created by the variant in this PR, since the separate QC task will not have access to the full information from during the tracking, but I think it will be useful nonetheless.
There are also some cuts / options already configurable via configKeyValues, will document them in the QC task once that is ready.
Ping @wiechula @shahor02 @stheckel @tklemenz @Barthelemy