feat: Add ReassignmentHandler which is notified on client reassignment - #242
#242Merged
dpcollins-google merged 3 commits intoSep 16, 2021
maingoogleapis/python-pubsublite:mainfrom
reassignment_handlergoogleapis/python-pubsublite:reassignment_handlerCopy head branch name to clipboard
Merged
feat: Add ReassignmentHandler which is notified on client reassignment#242dpcollins-google merged 3 commits intomaingoogleapis/python-pubsublite:mainfrom reassignment_handlergoogleapis/python-pubsublite:reassignment_handlerCopy head branch name to clipboard
dpcollins-google merged 3 commits into
maingoogleapis/python-pubsublite:mainfrom
reassignment_handlergoogleapis/python-pubsublite:reassignment_handlerCopy head branch name to clipboard
Conversation
This enables clients to respond to a reassignment by cancelling outstanding actions and nacking all messages.
tmdiep
approved these changes
Sep 16, 2021
| class ReassignmentHandler(ABC): | ||
| """ | ||
| A ReassignmentHandler is called any time a new partition assignment is received from the server. | ||
| It will be called with both the previous and new assignments as decided by the backend. |
Contributor
There was a problem hiding this comment.
Ditto comments from the Java PR.
Contributor
Author
There was a problem hiding this comment.
Copied over the docstring changes- python unfortunately cannot implement the stronger semantics around message delivery, but I've documented this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This enables clients to respond to a reassignment by cancelling outstanding actions and nacking all messages.