Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

fix: Ignore CONTRIBUTING.md#447

Merged
gcf-merge-on-green[bot] merged 2 commits into
mastergoogleapis/java-storage:masterfrom
ignore-contributinggoogleapis/java-storage:ignore-contributingCopy head branch name to clipboard
Aug 4, 2020
Merged

fix: Ignore CONTRIBUTING.md#447
gcf-merge-on-green[bot] merged 2 commits into
mastergoogleapis/java-storage:masterfrom
ignore-contributinggoogleapis/java-storage:ignore-contributingCopy head branch name to clipboard

Conversation

@frankyn

@frankyn frankyn commented Aug 3, 2020

Copy link
Copy Markdown
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a Ignore CONTRIBUTING.md #446 before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #446 ☕️

@frankyn
frankyn requested a review from dmitry-fa August 3, 2020 21:33
@google-cla google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 3, 2020
@frankyn frankyn added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 3, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 3, 2020
dmitry-fa
dmitry-fa approved these changes Aug 4, 2020
View reviewed changes

@dmitry-fa dmitry-fa left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@frankyn frankyn added automerge Merge the pull request once unit tests and other checks pass. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Aug 4, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 4, 2020
@gcf-merge-on-green

gcf-merge-on-green Bot commented Aug 4, 2020

Copy link
Copy Markdown

Your PR has attempted to merge for 3 hours. Please check that all required checks have passed, you have an automerge label, and that all your reviewers have approved the PR

@frankyn frankyn added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 4, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 4, 2020
@gcf-merge-on-green
gcf-merge-on-green Bot merged commit bdacdc9 into master Aug 4, 2020
@gcf-merge-on-green
gcf-merge-on-green Bot deleted the ignore-contributing branch August 4, 2020 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@dmitry-fa dmitry-fa dmitry-fa approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

automerge Merge the pull request once unit tests and other checks pass. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Ignore CONTRIBUTING.md

3 participants

@frankyn @dmitry-fa @yoshi-kokoro
Morty Proxy This is a proxified and sanitized view of the page, visit original site.