Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Add details to GoogleJsonResponseExceptions created with GoogleJsonResponseExceptionFactoryTesting#1395

Merged
chingor13 merged 2 commits into
googleapis:mastergoogleapis/google-api-java-client:masterfrom
SUPERCILEX:patch-1Copy head branch name to clipboard
Oct 21, 2019
Merged

Add details to GoogleJsonResponseExceptions created with GoogleJsonResponseExceptionFactoryTesting#1395
chingor13 merged 2 commits into
googleapis:mastergoogleapis/google-api-java-client:masterfrom
SUPERCILEX:patch-1Copy head branch name to clipboard

Conversation

@SUPERCILEX

Copy link
Copy Markdown
Contributor

Currently, GoogleJsonResponseExceptions created with GoogleJsonResponseExceptionFactoryTesting will have null #getDetails().

@SUPERCILEX
SUPERCILEX requested a review from a team October 20, 2019 22:07
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 20, 2019
@chingor13 chingor13 added the kokoro:run Add this label to force Kokoro to re-run the tests. label Oct 21, 2019
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Oct 21, 2019

@chingor13 chingor13 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting this.

@chingor13 chingor13 added the kokoro:run Add this label to force Kokoro to re-run the tests. label Oct 21, 2019
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Oct 21, 2019
@chingor13
chingor13 merged commit 1ffdba6 into googleapis:master Oct 21, 2019
@SUPERCILEX

Copy link
Copy Markdown
Contributor Author

Awesome, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.