Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings
This repository was archived by the owner on Sep 27, 2023. It is now read-only.

[api-common-java] Handle "-", _deleted-topic_ patterns#150

Merged
miraleung merged 1 commit into
mastergoogleapis/api-common-java:masterfrom
fixit/collection-wildcardsgoogleapis/api-common-java:fixit/collection-wildcardsCopy head branch name to clipboard
Jun 4, 2020
Merged

[api-common-java] Handle "-", _deleted-topic_ patterns#150
miraleung merged 1 commit into
mastergoogleapis/api-common-java:masterfrom
fixit/collection-wildcardsgoogleapis/api-common-java:fixit/collection-wildcardsCopy head branch name to clipboard

Conversation

@miraleung

Copy link
Copy Markdown
Contributor

Redoing #149 with a clean branch from master.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 4, 2020
@miraleung
miraleung requested review from noahdietz and vam-google June 4, 2020 00:13
@codecov

codecov Bot commented Jun 4, 2020

Copy link
Copy Markdown

Codecov Report

Merging #150 into master will increase coverage by 0.13%.
The diff coverage is 71.42%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #150      +/-   ##
============================================
+ Coverage     63.96%   64.09%   +0.13%     
- Complexity      163      171       +8     
============================================
  Files            14       14              
  Lines           702      713      +11     
  Branches        112      118       +6     
============================================
+ Hits            449      457       +8     
- Misses          219      220       +1     
- Partials         34       36       +2     
Impacted Files Coverage Δ Complexity Δ
...java/com/google/api/pathtemplate/PathTemplate.java 69.16% <71.42%> (+0.09%) 114.00 <0.00> (+8.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4caf2ca...fceb08d. Read the comment docs.

@miraleung
miraleung merged commit 8fb8068 into master Jun 4, 2020
@miraleung miraleung mentioned this pull request Jun 4, 2020
@chingor13 chingor13 mentioned this pull request Jun 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Explicitly support "_deleted-topic_" pattern Support "-" for cross-collection reading

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.