]> BookStack Code Mirror - bookstack/commitdiff
Fixed double brace issues in both editors.
authorDan Brown <redacted>
Sat, 13 Aug 2016 13:18:31 +0000 (14:18 +0100)
committerDan Brown <redacted>
Sat, 13 Aug 2016 13:18:31 +0000 (14:18 +0100)
Double braces were being parsed by angular in both the WYSIWYG and markdown editor.
Fixes #150 and fixes #155.

resources/assets/js/directives.js
resources/assets/sass/_tinymce.scss
resources/views/pages/form.blade.php

index 0119ded4210eb633be69303aa9422fac39aff920..8554da9f8d2b70f6a81c6989d858277a94b58d92 100644 (file)
@@ -252,11 +252,14 @@ module.exports = function (ngApp, events) {
             link: function (scope, element, attrs) {
 
                 // Set initial model content
-                var content = element.val();
+                element = element.find('textarea').first();
+                let content = element.val();
                 scope.mdModel = content;
                 scope.mdChange(markdown(content));
 
-                element.on('change input', (e) => {
+                console.log('test');
+
+                element.on('change input', (event) => {
                     content = element.val();
                     $timeout(() => {
                         scope.mdModel = content;
@@ -284,7 +287,7 @@ module.exports = function (ngApp, events) {
             link: function (scope, element, attrs) {
 
                 // Elements
-                const input = element.find('textarea[markdown-input]');
+                const input = element.find('[markdown-input] textarea').first();
                 const display = element.find('.markdown-display').first();
                 const insertImage = element.find('button[data-action="insertImage"]');
 
index 2c3571d4b44c4e8014a1e0e2b45f0891ff53f16e..dd0bf7950bb3912e88aa625505e63b9479468929 100644 (file)
@@ -24,7 +24,7 @@
   text-align: center;
 }
 
-.edit-area.flex > .mce-tinymce.mce-container.mce-panel {
+.edit-area.flex > div > .mce-tinymce.mce-container.mce-panel {
   height: 100%;
   max-height: 100%;
   flex: 1;
index 4196e946fc8b8398e5c7074715270895740995b9..6529f044b5f5b222b2ba7bdcf6a6d8bc58f7c2cb 100644 (file)
 
     <div class="edit-area flex-fill flex">
         @if(setting('app-editor') === 'wysiwyg')
-            <textarea id="html-editor" tinymce="editorOptions" mce-change="editorChange" mce-model="editContent"  name="html" rows="5"
-                      @if($errors->has('html')) class="neg" @endif>@if(isset($model) || old('html')){{htmlspecialchars( old('html') ? old('html') : $model->html)}}@endif</textarea>
+            <div tinymce="editorOptions" mce-change="editorChange" mce-model="editContent" class="flex-fill flex">
+                <textarea id="html-editor"   name="html" rows="5" ng-non-bindable
+                          @if($errors->has('html')) class="neg" @endif>@if(isset($model) || old('html')){{htmlspecialchars( old('html') ? old('html') : $model->html)}}@endif</textarea>
+            </div>
+
             @if($errors->has('html'))
                 <div class="text-neg text-small">{{ $errors->first('html') }}</div>
             @endif
                             <button class="text-button" type="button" data-action="insertImage"><i class="zmdi zmdi-image"></i>Insert Image</button>
                         </div>
                     </div>
-                    <textarea markdown-input md-change="editorChange" id="markdown-editor-input" md-model="editContent"  name="markdown" rows="5"
-                              @if($errors->has('markdown')) class="neg" @endif>@if(isset($model) || old('markdown')){{htmlspecialchars( old('markdown') ? old('markdown') : ($model->markdown === '' ? $model->html : $model->markdown))}}@endif</textarea>
+
+                    <div markdown-input md-change="editorChange" md-model="editContent" class="flex flex-fill">
+                        <textarea ng-non-bindable id="markdown-editor-input"  name="markdown" rows="5"
+                                  @if($errors->has('markdown')) class="neg" @endif>@if(isset($model) || old('markdown')){{htmlspecialchars( old('markdown') ? old('markdown') : ($model->markdown === '' ? $model->html : $model->markdown))}}@endif</textarea>
+                    </div>
+
                 </div>
 
                 <div class="markdown-editor-wrap">
Morty Proxy This is a proxified and sanitized view of the page, visit original site.