Fish completions no longer suggest subcommands that have already been picked - #2117
#2117Merged
dearchap merged 1 commit intoApr 27, 2025
urfave:mainurfave/cli:mainfrom
bittrance:fish-completion-repetitionbittrance/urfave-cli:fish-completion-repetitionCopy head branch name to clipboard
Merged
Fish completions no longer suggest subcommands that have already been picked#2117dearchap merged 1 commit intourfave:mainurfave/cli:mainfrom bittrance:fish-completion-repetitionbittrance/urfave-cli:fish-completion-repetitionCopy head branch name to clipboard
dearchap merged 1 commit into
urfave:mainurfave/cli:mainfrom
bittrance:fish-completion-repetitionbittrance/urfave-cli:fish-completion-repetitionCopy head branch name to clipboard
Conversation
Contributor
Author
|
The refactored helpers in this PR will need to be further extended along the same lines to include the lineage of a sub-command in order to address #2115. |
dearchap
approved these changes
Apr 27, 2025
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Stop fish completions suggesting sub-commands from the level you just picked from.
Which issue(s) this PR fixes:
Fixes #2116 .
Special notes for your reviewer:
This solution tries to minimize the size of this change. It is possible and arguably easier to read to use multiple
-nwhich will be and:ed together for you.Testing
See #2116 for test code.
Release Notes