Fix:(issue_2105) Ensure fish completion works - #2106
#2106Merged
Merged
Fix:(issue_2105) Ensure fish completion works#2106
Conversation
Contributor
Author
|
cc @yjp20 can you try this commit ? |
suzuki-shunsuke
approved these changes
Apr 21, 2025
|
This looks good, though I'm confused why you'd thread through appName if you can always do |
Contributor
Author
|
@yjp20 The appName is needed for other shells !!! |
|
@dearchap and why would cmd.Root().Name not always work? sorry, just a little confused by that. |
Contributor
Author
|
@yjp20 Yes it would work. I can reopen your PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
(REQUIRED)
What this PR does / why we need it:
(REQUIRED)
Which issue(s) this PR fixes:
(REQUIRED)
Fixes #2105
Special notes for your reviewer:
(fill-in or delete this section)
Testing
(fill-in or delete this section)
Release Notes
(REQUIRED)