Parse device brand and model - #28
#28Merged
Merged
Parse device brand and model#28
Conversation
Update to latest uap-core as previously referenced commit is no longer available
Contributor
|
Thanks @seandilda. This looks good to me. Would you mind rebasing from master to resolve the conflict? |
Contributor
|
Hey @seandilda Do you expect to be able to do the rebase soon? I'd be happy to bring in these changes once done |
Contributor
|
Thanks! @toolmantim any objections? |
Contributor
|
None here @wallin! I no longer use the gem, so I'm happy for you to make executive calls 😊 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds parsing for the device brand and model.
It also updates to latest uap-core as previously referenced commit is no longer available