Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Fix matrix example syntax in troubleshooting docs - #4591

#4591
Merged
thomhurst merged 1 commit into
mainthomhurst/TUnit:mainfrom
fix/matrix-docs-syntaxthomhurst/TUnit:fix/matrix-docs-syntaxCopy head branch name to clipboard
Jan 28, 2026
Merged

Fix matrix example syntax in troubleshooting docs#4591
thomhurst merged 1 commit into
mainthomhurst/TUnit:mainfrom
fix/matrix-docs-syntaxthomhurst/TUnit:fix/matrix-docs-syntaxCopy head branch name to clipboard

Conversation

@thomhurst

Copy link
Copy Markdown
Owner

Fixes the matrix test explosion example to use the actual [MatrixDataSource] and [Matrix] syntax instead of [Arguments].

Closes #4590

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@thomhurst

Copy link
Copy Markdown
Owner Author

Summary

Updates the Matrix Test Explosion example in troubleshooting documentation to use the correct [MatrixDataSource] syntax.

Critical Issues

None found ✅

Suggestions

The documentation change is accurate and improves clarity. The updated example correctly demonstrates:

  • Using [MatrixDataSource] attribute on the test method
  • Using [Matrix(...)] attributes on individual parameters
  • The resulting combinatorial explosion (5 × 5 × 2 = 50)

The previous example used multiple [Arguments] attributes which would have generated 12 test cases (3 from the three [Arguments] lines, each with different argument counts), not a 50-case matrix explosion. The corrected example properly illustrates the troubleshooting scenario.

One minor suggestion: Consider adding using TUnit.Core; to the example snippet for completeness, though it's not critical for a troubleshooting doc.

Verdict

APPROVE - No critical issues

@thomhurst
thomhurst merged commit 7a4a3de into main Jan 28, 2026
13 checks passed
@thomhurst
thomhurst deleted the fix/matrix-docs-syntax branch January 28, 2026 21:16
This was referenced Jan 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Matrix example in troubleshooting has wrong syntax

1 participant

Morty Proxy This is a proxified and sanitized view of the page, visit original site.