Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Privacy plugin: more accurate pattern to capture external links#8542

Merged
squidfunk merged 1 commit into
squidfunk:mastersquidfunk/mkdocs-material:masterfrom
emaheuxPEREN:plugin_privacy_fix_external_link_patternemaheuxPEREN/mkdocs-material:plugin_privacy_fix_external_link_patternCopy head branch name to clipboard
Dec 18, 2025
Merged

Privacy plugin: more accurate pattern to capture external links#8542
squidfunk merged 1 commit into
squidfunk:mastersquidfunk/mkdocs-material:masterfrom
emaheuxPEREN:plugin_privacy_fix_external_link_patternemaheuxPEREN/mkdocs-material:plugin_privacy_fix_external_link_patternCopy head branch name to clipboard

Conversation

@emaheuxPEREN

Copy link
Copy Markdown
Contributor

Use a more accurate pattern to capture external links in privacy plugin.

Fix is two-fold:

  • avoid false-positive for internal links that starts with http
  • avoid false-negative for scheme-less links, e.g. //x.y.z/

@squidfunk

squidfunk commented Dec 11, 2025

Copy link
Copy Markdown
Owner

Thanks for the PR. Please provide a minimal reproduction, so we can observe the errors this PR is trying to fix + decide whether it is worth integrating. Please note that this project is now in maintenance mode.

@emaheuxPEREN

Copy link
Copy Markdown
Contributor Author

Here you are :
9.7.0-privacy-external-links-pr8542.zip

@squidfunk

Copy link
Copy Markdown
Owner

Thanks for providing the reproduction, looks good!

@squidfunk
squidfunk merged commit dde13ce into squidfunk:master Dec 18, 2025
@squidfunk

Copy link
Copy Markdown
Owner

Another fix was necessary to make protocol-relative URLs work. I'm not sure why this worked on your machine, but requests failed with being able to fetch the URL. Fixed in 79ba428.

@Montiwa11 Montiwa11 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CameronWhiteside:x402/agentic-setup-improvements

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.