Clarify semantics of HttpMethod.valueOf()#36652
Merged
sbrannen merged 1 commit intoApr 14, 2026
spring-projects:7.0.xspring-projects/spring-framework:7.0.xfrom
angry-2k:gh-36642-httpmethod-valueof-docangry-2k/spring-framework:gh-36642-httpmethod-valueof-docCopy head branch name to clipboard
Merged
Clarify semantics of HttpMethod.valueOf()#36652sbrannen merged 1 commit intospring-projects:7.0.xspring-projects/spring-framework:7.0.xfrom angry-2k:gh-36642-httpmethod-valueof-docangry-2k/spring-framework:gh-36642-httpmethod-valueof-docCopy head branch name to clipboard
sbrannen merged 1 commit into
spring-projects:7.0.xspring-projects/spring-framework:7.0.xfrom
angry-2k:gh-36642-httpmethod-valueof-docangry-2k/spring-framework:gh-36642-httpmethod-valueof-docCopy head branch name to clipboard
Conversation
HttpMethod.valueOf() performs a case-sensitive lookup of predefined
HttpMethod constants. For example, valueOf("GET") resolves to
HttpMethod.GET, whereas valueOf("get") results in a newly created
HttpMethod instance.
Update the Javadoc to explicitly document this behavior.
Closes spring-projectsgh-36642
Signed-off-by: angry-2k <edkev@kakao.com>
sbrannen
added a commit
that referenced
this pull request
Apr 14, 2026
sbrannen
pushed a commit
that referenced
this pull request
Apr 14, 2026
HttpMethod.valueOf() performs a case-sensitive lookup of predefined
HttpMethod constants. For example, valueOf("GET") resolves to
HttpMethod.GET, whereas valueOf("get") results in a newly created
HttpMethod instance.
Update the Javadoc to explicitly document this behavior.
See gh-36642
Closes gh-36652
Signed-off-by: angry-2k <edkev@kakao.com>
(cherry picked from commit df82845)
Member
sbrannen
added a commit
that referenced
this pull request
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the Javadoc for
HttpMethod.valueOf()to explicitly document that it performs a case-sensitive lookup.As requested by @sbrannen in gh-36642, this change is being submitted against the
7.0.xbranch to document the status quo.Motivation
The current behavior of
HttpMethod.valueOf()can be ambiguous. This update ensures that developers understand:"GET") resolve to predefined constants."get") result in a newly createdHttpMethodinstance.Modifications
valueOf(String)Javadoc inHttpMethod.javawith clear examples of case-sensitive resolution.Closes gh-36642