Fix function call message change for small number of args - #21432
#21432Merged
hauntsaninja merged 2 commits intoMay 10, 2026
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
KevinRK29
approved these changes
May 9, 2026
Collaborator
|
makes sense to me, thanks! |
Contributor
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
JukkaL
pushed a commit
that referenced
this pull request
May 10, 2026
Refs #21427 I used `2` as a magic number, because in my opinion it is easier to tell the difference when all errors show up for the small number of args. --------- Co-authored-by: hauntsaninja <hauntsaninja@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #21427
I used
2as a magic number, because in my opinion it is easier to tell the difference when all errors show up for the small number of args.Any feedback is welcome 👍