feat: add GitHub artifact attestation trusted root - #88
#88Merged
Merged
feat: add GitHub artifact attestation trusted root#88
Conversation
Member
|
I can have a closer look on mon/tue but as initial comment:
Adding the Github embedded trustroot without TUF support is annoying but understandable if there's yet another compat issue with the TUF repos, so otherwise this seems good to me. |
Signed-off-by: Wolf Vollprecht <w.vollprecht@gmail.com>
jku
approved these changes
May 13, 2026
jku
left a comment
Member
There was a problem hiding this comment.
Thanks, this looks reasonable to me, no notes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds first-class trust-root support for GitHub artifact attestations while keeping instance selection explicit.
GitHub artifact attestations use GitHub's own Sigstore instance, not the public-good Sigstore root. This PR adds the GitHub TUF URL/root constants and embedded GitHub
trusted_root.jsonsnapshot so callers can actively choose the GitHub instance when verifying GitHub attestations.The preferred API remains TUF-backed loading via
TrustedRoot::from_tuf(...). For GitHub,TufConfig::github()is available, but live fetching is not wired as the default because the currenttoughverifier rejects GitHub's TUF root metadata key IDs. Until that compatibility issue is fixed, GitHub verification can explicitly opt into the embedded GitHub trusted-root snapshot withTrustedRoot::from_embedded(SigstoreInstance::GitHub).This also keeps verification policy explicit: GitHub artifact attestations should be verified with the GitHub root and a policy that skips Rekor/tlog and SCT checks while preserving certificate-chain and RFC 3161 timestamp verification.
Release Note
Added GitHub artifact attestation trust-root support, including GitHub TUF configuration and an explicit embedded GitHub trusted-root fallback.
Documentation
Updated crate READMEs with explicit public Sigstore/GitHub trust-root selection and GitHub verification usage.