Allow multiple new lines in union and intersection declaration - #265
#265Merged
ondrejmirtes merged 1 commit intoFeb 17, 2025
phpstan:2.0.xphpstan/phpdoc-parser:2.0.xfrom
DaDeather:258-allow-new-lines-inbetween-type-declarations-extended-multilineDaDeather/phpdoc-parser:258-allow-new-lines-inbetween-type-declarations-extended-multilineCopy head branch name to clipboard
Merged
Allow multiple new lines in union and intersection declaration#265ondrejmirtes merged 1 commit intophpstan:2.0.xphpstan/phpdoc-parser:2.0.xfrom DaDeather:258-allow-new-lines-inbetween-type-declarations-extended-multilineDaDeather/phpdoc-parser:258-allow-new-lines-inbetween-type-declarations-extended-multilineCopy head branch name to clipboard
ondrejmirtes merged 1 commit into
phpstan:2.0.xphpstan/phpdoc-parser:2.0.xfrom
DaDeather:258-allow-new-lines-inbetween-type-declarations-extended-multilineDaDeather/phpdoc-parser:258-allow-new-lines-inbetween-type-declarations-extended-multilineCopy head branch name to clipboard
Conversation
DaDeather
force-pushed
the
258-allow-new-lines-inbetween-type-declarations-extended-multiline
branch
from
February 16, 2025 14:48
9d5ff82 to
edfe931
Compare
mvorisek
reviewed
Feb 17, 2025
|
|
||
| yield [ | ||
| 'Multiline PHPDoc with multiple new line within union type declaration', | ||
| '/**' . PHP_EOL . |
Contributor
There was a problem hiding this comment.
nowdoc can be used here for more readability
Member
There was a problem hiding this comment.
But maybe not because that's only in PrinterTest.
ondrejmirtes
force-pushed
the
258-allow-new-lines-inbetween-type-declarations-extended-multiline
branch
from
February 17, 2025 20:24
edfe931 to
3a918f8
Compare
Member
|
Thank you! |
Contributor
Author
Sure, happy to help! But rather thank you for also fixing the tests that failed in this regard! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I just noticed that my latest implementation only allowed a "single" new line in between the type declaration for union and intersection types.
See:
https://phpstan.org/r/107386a9-94b0-4dc1-bc22-ac2d6db189c4
This change would allow multiple new lines between those to be handled correctly.