Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release readiness review (v0.18.2 -> TARGET origin/main@d02972ef57c3de995147cb18dec5377386eaa3ab)
This is a release readiness report done by
$final-release-reviewskill.Diff
v0.18.2...d02972e
Release call:
🟢 GREEN LIGHT TO SHIP No confirmed regressions, breaking changes, or release-critical failures were found; 644 focused tests passed.
Scope summary:
Risk assessment (ordered by impact):
Runner retry and prepared-item identity changes
5313a8299andd02972ef5narrowly correct rewind and identity behavior with regression coverage; the runner and conversation-tracker tests passed.src/agents/run_internal/run_loop.py,src/agents/run_internal/oai_conversation.pytests/test_agent_runner_streamed.pyandtests/test_server_conversation_tracker.pyto remain green in release CI; locally satisfied.AdvancedSQLiteSession transactional and concurrency expansion
clear_session(),pop_item(), branch pointers, and usage persistence are stateful mutation paths with data-integrity impact.src/agents/extensions/memory/advanced_sqlite_session.py,tests/extensions/memory/test_advanced_sqlite_session.pyRealtime response usage accounting
response.doneusage fields in the [OpenAI Realtime cost guide](https://developers.openai.com/api/docs/guides/realtime-costs#example); focused Realtime tests passed.src/agents/realtime/model_events.py,src/agents/realtime/openai_realtime.py,src/agents/realtime/session.pyTracing, provider validation, schema bounds, and error redaction
src/agents/tracing/config.py,src/agents/models/openai_provider.py,src/agents/strict_schema.py,src/agents/util/_error_tracing.pyTracing option is not documented in the user guide
include_task_and_turn_spansappears in its type docstring but not indocs/tracing.md,docs/config.md, ordocs/running_agents.md.src/agents/tracing/config.py,docs/tracing.mdRunConfig(tracing={"include_task_and_turn_spans": False})example in a follow-up documentation change.Notes:
origin/mainwere refreshed; base isv0.18.2, target isd02972ef57c3de995147cb18dec5377386eaa3ab.git diff --checkpassed.644 passed in 6.91s. An initial run inherited a local SOCKS proxy and failed before changed assertions; removing proxy variables produced the clean result..agents/skills/quick-win-fixes/directory; it was untouched and excluded from the release diff.