fix(schema): enable HMR for defineNuxtComponent in JSX - #35620
#35620Merged
danielroe merged 2 commits intoJul 17, 2026
mainnuxt/nuxt:mainfrom
fix/tsx-defineNuxtComponent-hmrnuxt/nuxt:fix/tsx-defineNuxtComponent-hmrCopy head branch name to clipboard
Merged
fix(schema): enable HMR for defineNuxtComponent in JSX#35620danielroe merged 2 commits intomainnuxt/nuxt:mainfrom fix/tsx-defineNuxtComponent-hmrnuxt/nuxt:fix/tsx-defineNuxtComponent-hmrCopy head branch name to clipboard
danielroe merged 2 commits into
mainnuxt/nuxt:mainfrom
fix/tsx-defineNuxtComponent-hmrnuxt/nuxt:fix/tsx-defineNuxtComponent-hmrCopy head branch name to clipboard
Conversation
danielroe
enabled auto-merge
July 17, 2026 11:29
This comment has been minimized.
This comment has been minimized.
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/schema/src/config/vite.ts`:
- Around line 74-78: Update the returned options object in the Vite
configuration flow to spread options before assigning the enforced
isCustomElement and defineComponentName fields. Preserve the compiler-derived
isCustomElement handler and ensure defineComponentName always includes
defineNuxtComponent, even when user options provide overrides.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: f8cc5cfb-d271-46d3-b9fd-7685ff9620fd
📒 Files selected for processing (1)
packages/schema/src/config/vite.ts
Comment on lines
74
to
+78
| return { | ||
| // TODO: investigate type divergence between types for @vue/compiler-core and @vue/babel-plugin-jsx | ||
| isCustomElement: (await get('vue')).compilerOptions?.isCustomElement as undefined | ((tag: string) => boolean), | ||
| ...typeof val === 'object' ? val : {}, | ||
| defineComponentName: [...new Set([...options.defineComponentName ?? ['defineComponent'], 'defineNuxtComponent'])], | ||
| ...options, |
Contributor
There was a problem hiding this comment.
🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
Apply enforced options after spreading user options.
...options on Line 78 overwrites both values calculated above. A configured defineComponentName can therefore omit defineNuxtComponent, and a configured isCustomElement can replace the compiler-derived handler. Spread options first, then assign these enforced fields.
Proposed fix
return {
+ ...options,
// TODO: investigate type divergence between types for `@vue/compiler-core` and `@vue/babel-plugin-jsx`
isCustomElement: (await get('vue')).compilerOptions?.isCustomElement as undefined | ((tag: string) => boolean),
defineComponentName: [...new Set([...options.defineComponentName ?? ['defineComponent'], 'defineNuxtComponent'])],
- ...options,
}📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| return { | |
| // TODO: investigate type divergence between types for @vue/compiler-core and @vue/babel-plugin-jsx | |
| isCustomElement: (await get('vue')).compilerOptions?.isCustomElement as undefined | ((tag: string) => boolean), | |
| ...typeof val === 'object' ? val : {}, | |
| defineComponentName: [...new Set([...options.defineComponentName ?? ['defineComponent'], 'defineNuxtComponent'])], | |
| ...options, | |
| return { | |
| ...options, | |
| // TODO: investigate type divergence between types for `@vue/compiler-core` and `@vue/babel-plugin-jsx` | |
| isCustomElement: (await get('vue')).compilerOptions?.isCustomElement as undefined | ((tag: string) => boolean), | |
| defineComponentName: [...new Set([...options.defineComponentName ?? ['defineComponent'], 'defineNuxtComponent'])], | |
| } |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@packages/schema/src/config/vite.ts` around lines 74 - 78, Update the returned
options object in the Vite configuration flow to spread options before assigning
the enforced isCustomElement and defineComponentName fields. Preserve the
compiler-derived isCustomElement handler and ensure defineComponentName always
includes defineNuxtComponent, even when user options provide overrides.
@nuxt/kit
@nuxt/nitro-server
nuxt
@nuxt/rspack-builder
@nuxt/schema
@nuxt/vite-builder
@nuxt/webpack-builder
commit: |
Merging this PR will not alter performance
Comparing Footnotes
|
huang-julien
approved these changes
Jul 17, 2026
danielroe
added a commit
that referenced
this pull request
Jul 17, 2026
Closed
danielroe
added a commit
that referenced
this pull request
Jul 17, 2026
danielroe
added a commit
that referenced
this pull request
Jul 17, 2026
danielroe
added a commit
that referenced
this pull request
Jul 17, 2026
danielroe
added a commit
that referenced
this pull request
Jul 17, 2026
danielroe
added a commit
that referenced
this pull request
Jul 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
resolves #35465
📚 Description
this adds
defineNuxtComponentto the list of component factories with HMR