Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

fix(nuxt): preserve setPageLayout props on same-path navigation#35055

Merged
danielroe merged 2 commits into
mainnuxt/nuxt:mainfrom
fix/set-page-layout-propsnuxt/nuxt:fix/set-page-layout-propsCopy head branch name to clipboard
May 11, 2026
Merged

fix(nuxt): preserve setPageLayout props on same-path navigation#35055
danielroe merged 2 commits into
mainnuxt/nuxt:mainfrom
fix/set-page-layout-propsnuxt/nuxt:fix/set-page-layout-propsCopy head branch name to clipboard

Conversation

@DamianGlowala

@DamianGlowala DamianGlowala commented May 11, 2026

Copy link
Copy Markdown
Member

🔗 Linked issue

resolves #34845

📚 Description

When not in middleware and performing client-side same-path navigation, we are now preserving layout and layout props in the beforeResolve hook.

@DamianGlowala
DamianGlowala requested a review from danielroe as a code owner May 11, 2026 16:21
@bolt-new-by-stackblitz

bolt-new-by-stackblitz Bot commented May 11, 2026

Copy link
Copy Markdown

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@coderabbitai

This comment has been minimized.

Sign in to view
@github-actions github-actions Bot added 5.x 🐛 bug Something isn't working as expected labels May 11, 2026
@pkg-pr-new

pkg-pr-new Bot commented May 11, 2026

Copy link
Copy Markdown

Open in StackBlitz

@nuxt/kit

npm i https://pkg.pr.new/@nuxt/kit@35055

@nuxt/nitro-server

npm i https://pkg.pr.new/@nuxt/nitro-server@35055

nuxt

npm i https://pkg.pr.new/nuxt@35055

@nuxt/rspack-builder

npm i https://pkg.pr.new/@nuxt/rspack-builder@35055

@nuxt/schema

npm i https://pkg.pr.new/@nuxt/schema@35055

@nuxt/vite-builder

npm i https://pkg.pr.new/@nuxt/vite-builder@35055

@nuxt/webpack-builder

npm i https://pkg.pr.new/@nuxt/webpack-builder@35055

commit: 7d45ce7

@codspeed-hq

codspeed-hq Bot commented May 11, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 20 untouched benchmarks
⏩ 3 skipped benchmarks1

Comparing fix/set-page-layout-props (7d45ce7) with main (0e566fa)

Open in CodSpeed

Footnotes

  1. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@danielroe
danielroe merged commit dfb4319 into main May 11, 2026
28 checks passed
@danielroe
danielroe deleted the fix/set-page-layout-props branch May 11, 2026 17:04
This was referenced May 11, 2026
Open
Draft
danielroe pushed a commit that referenced this pull request May 11, 2026
@DamianGlowala @danielroe
fix(nuxt): preserve setPageLayout props on same-path navigation (#3…
4bdd9dd 
…5055)
@github-actions github-actions Bot mentioned this pull request May 11, 2026
Merged
danielroe pushed a commit that referenced this pull request May 13, 2026
@DamianGlowala @danielroe
fix(nuxt): preserve setPageLayout props on same-path navigation (#3…
702c02b 
…5055)
@github-actions github-actions Bot mentioned this pull request May 13, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danielroe danielroe danielroe approved these changes

Assignees

No one assigned

Labels

5.x 🐛 bug Something isn't working as expected

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

setPageLayout props are lost on same-path (query-only) navigations

2 participants

@DamianGlowala @danielroe
Morty Proxy This is a proxified and sanitized view of the page, visit original site.