Revisit remaining NonParallelizable and Ignore - #6339
#6339Revisit remaining NonParallelizable and Ignore#6339
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR addresses issue #4103 by removing or updating [NonParallelizable] and [Ignore] test attributes that are no longer necessary. The changes enable previously disabled tests to run and updates them with corrected assertions and expectations.
- Removes
[NonParallelizable]attributes from tests that no longer require sequential execution - Re-enables multiple previously ignored tests with updated assertions to match current behavior
- Updates test expectations for parameter type inference to reflect
Unknowninstead ofTextfor null/DBNull values - Corrects test data and assertions in DataAdapter tests
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| test/Npgsql.Tests/Types/TextTests.cs | Removes [NonParallelizable] from Citext_as_string test |
| test/Npgsql.Tests/Types/RangeTests.cs | Removes [NonParallelizable] from Unmapped_range_with_mapped_subtype test |
| test/Npgsql.Tests/Types/MultirangeTests.cs | Removes [NonParallelizable] from Unmapped_multirange_with_mapped_subtype test |
| test/Npgsql.Tests/TypeMapperTests.cs | Removes [NonParallelizable] from two citext-related tests and clarifies comment for remaining one |
| test/Npgsql.Tests/NpgsqlParameterTests.cs | Re-enables three previously ignored tests with updated expectations for type inference behavior, removes unused import |
| test/Npgsql.Tests/DataAdapterTests.cs | Re-enables five tests with corrected column names, assertions, and table schema definition |
| test/Npgsql.Tests/CopyTests.cs | Re-enables test with corrected exception type expectation (NpgsqlException instead of IOException) |
| test/Npgsql.Tests/ConnectionTests.cs | Replaces hard [Ignore] with conditional multiplexing check and updates expected error code |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
739350d to
59671e2
Compare
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 8 out of 8 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 8 out of 8 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
roji
left a comment
There was a problem hiding this comment.
Just hoping this doesn't introduce flakiness into the build - am assuming these are fine since we switched to data source (which provides isolation)?
Closes #4103