Commit 1780bbc
tls: validate "rejectUnauthorized: undefined"
Incomplete validation of rejectUnauthorized parameter (Low)
If the Node.js https API was used incorrectly and "undefined" was passed
in for the "rejectUnauthorized" parameter, no error was returned and
connections to servers with an expired certificate would have been
accepted.
CVE-ID: CVE-2021-22939
Refs: https://nvd.nist.gov/vuln/detail/CVE-2021-22939
Refs: https://hackerone.com/reports/1278254
PR-URL: nodejs-private/node-private#276
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Akshay K <iit.akshay@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Richard Lau <rlau@redhat.com>1 parent 9cd1f53 commit 1780bbcCopy full SHA for 1780bbc
2 files changed
+29-1Lines changed: 29 additions & 1 deletion
File tree
Expand file treeCollapse file tree
Open diff view settings
Filter options
- lib
- test/parallel
Expand file treeCollapse file tree
Open diff view settings
Collapse file
+16-1Lines changed: 16 additions & 1 deletion
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
1516 | 1516 | |
1517 | 1517 | |
1518 | 1518 | |
1519 | | - |
| 1519 | + |
| 1520 | + |
| 1521 | + |
| 1522 | + |
| 1523 | + |
| 1524 | + |
| 1525 | + |
| 1526 | + |
| 1527 | + |
1520 | 1528 | |
1521 | 1529 | |
1522 | 1530 | |
| ||
1598 | 1606 | |
1599 | 1607 | |
1600 | 1608 | |
| 1609 | + |
| 1610 | + |
| 1611 | + |
| 1612 | + |
| 1613 | + |
| 1614 | + |
| 1615 | + |
1601 | 1616 | |
1602 | 1617 | |
1603 | 1618 | |
|
Collapse file
test/parallel/test-tls-client-reject.js
Copy file name to clipboardExpand all lines: test/parallel/test-tls-client-reject.js+13Lines changed: 13 additions & 0 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
71 | 71 | |
72 | 72 | |
73 | 73 | |
| 74 | + |
| 75 | + |
| 76 | + |
| 77 | + |
| 78 | + |
| 79 | + |
| 80 | + |
| 81 | + |
| 82 | + |
| 83 | + |
| 84 | + |
| 85 | + |
| 86 | + |
74 | 87 | |
75 | 88 | |
76 | 89 | |
|
0 commit comments