Merged
Conversation
bording
marked this pull request as ready for review
November 9, 2021 03:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moving to a
netcoreapp3.1TFM made it possible to use theNativeLibraryAPI directly instead of through reflection.As part of this change it was also clear that the
NativeLibraryPathproperty should be consistent, so it will no longer append the architecture to the path when running on .NET Framework.This PR also includes a change to use
RuntimeInformation.ProcessArchitectureinstead of assuming x86 and x64 are the only two options. This will be increasingly untrue with all of the ARM support being added recently.