Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

docs: add guide on directives#4401

Merged
JoviDeCroock merged 4 commits into
graphql:16.x.xgraphql/graphql-js:16.x.xfrom
sarahxsanders:directivessarahxsanders/graphql-js:directivesCopy head branch name to clipboard
May 27, 2025
Merged

docs: add guide on directives#4401
JoviDeCroock merged 4 commits into
graphql:16.x.xgraphql/graphql-js:16.x.xfrom
sarahxsanders:directivessarahxsanders/graphql-js:directivesCopy head branch name to clipboard

Conversation

@sarahxsanders

@sarahxsanders sarahxsanders commented May 19, 2025

Copy link
Copy Markdown
Contributor

Adds guide "Using Directives in GraphQL.js"

@sarahxsanders
sarahxsanders marked this pull request as ready for review May 20, 2025 00:02
@sarahxsanders
sarahxsanders requested a review from a team as a code owner May 20, 2025 00:02
JoviDeCroock
JoviDeCroock approved these changes May 20, 2025
View reviewed changes
Comment thread website/pages/docs/using-directives.mdx Outdated
@sarahxsanders

sarahxsanders commented May 20, 2025

Copy link
Copy Markdown
Contributor Author

Resolved that feedback, thank you @JoviDeCroock!!

@JoviDeCroock
JoviDeCroock merged commit 1f1d89d into graphql:16.x.x May 27, 2025
@benjie benjie mentioned this pull request May 29, 2025
Merged
benjie
benjie reviewed May 29, 2025
View reviewed changes

@benjie benjie left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent docs; the only thing I felt was missing was that we should advise users not to use directives where field arguments could be used instead. I've raised this advice as #4417

benjie added a commit that referenced this pull request May 29, 2025
@benjie
Indicate that field arguments should always be preferred over directi…
90aaadc 
…ves (#4417)

Follow up to #4401
yaacovCR pushed a commit to yaacovCR/graphql-js that referenced this pull request May 30, 2025
@sarahxsanders @yaacovCR
docs: add guide on directives (graphql#4401)
a850f0e 
Adds guide "Using Directives in GraphQL.js"
yaacovCR pushed a commit that referenced this pull request May 30, 2025
@sarahxsanders @yaacovCR
docs: add guide on directives (#4401)
043d098 
Adds guide "Using Directives in GraphQL.js"
yaacovCR pushed a commit to yaacovCR/graphql-js that referenced this pull request May 30, 2025
@benjie @yaacovCR
Indicate that field arguments should always be preferred over directi…
0bfba7c 
…ves (graphql#4417)

Follow up to graphql#4401
yaacovCR pushed a commit that referenced this pull request May 30, 2025
@benjie @yaacovCR
Indicate that field arguments should always be preferred over directi…
c431fc0 
…ves (#4417)

Follow up to #4401
This was referenced Jun 3, 2026
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benjie benjie benjie left review comments
+1 more reviewer
@JoviDeCroock JoviDeCroock JoviDeCroock approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

PR: docs 📝

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sarahxsanders @benjie @JoviDeCroock
Morty Proxy This is a proxified and sanitized view of the page, visit original site.