Require non-empty directive locations#4100
Merged
benjie merged 1 commit intoJun 21, 2024
graphql:maingraphql/graphql-js:mainfrom
jbellenger:jbellenger-require-directive-locationsjbellenger/graphql-js:jbellenger-require-directive-locationsCopy head branch name to clipboard
Merged
Require non-empty directive locations#4100benjie merged 1 commit intographql:maingraphql/graphql-js:mainfrom jbellenger:jbellenger-require-directive-locationsjbellenger/graphql-js:jbellenger-require-directive-locationsCopy head branch name to clipboard
benjie merged 1 commit into
graphql:maingraphql/graphql-js:mainfrom
jbellenger:jbellenger-require-directive-locationsjbellenger/graphql-js:jbellenger-require-directive-locationsCopy head branch name to clipboard
Conversation
✅ Deploy Preview for compassionate-pike-271cb3 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
jbellenger
marked this pull request as ready for review
June 2, 2024 19:20
JoviDeCroock
approved these changes
Jun 10, 2024
|
Hi @jbellenger, I'm @github-actions bot happy to help you with this PR 👋 Supported commandsPlease post this commands in separate comments and only one per comment:
|
benjie
pushed a commit
that referenced
this pull request
Jul 1, 2024
benjie
pushed a commit
that referenced
this pull request
Jul 1, 2024
benjie
pushed a commit
that referenced
this pull request
Jul 1, 2024
benjie
added a commit
that referenced
this pull request
Sep 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A proposed spec edit clarifies a requirement that was always true but was slightly buried: directive definitions must include 1 or more locations.
This PR adds explicit validation to graphql-js around non-empty directive locations. Similar work was landed in graphql-java.
I'll add that I haven't contributed to graphql-js before and am not familiar with typescript or the mores of graphql-js. I've tried to follow existing patterns but would appreciate any feedback offered.