Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings
This repository was archived by the owner on May 7, 2026. It is now read-only.

feat: make all and any compatible with integer columns on Polars session#2154

Merged
tswast merged 47 commits into
maingoogleapis/python-bigquery-dataframes:mainfrom
tswast-polars-session-namesgoogleapis/python-bigquery-dataframes:tswast-polars-session-namesCopy head branch name to clipboard
Oct 14, 2025
Merged

feat: make all and any compatible with integer columns on Polars session#2154
tswast merged 47 commits into
maingoogleapis/python-bigquery-dataframes:mainfrom
tswast-polars-session-namesgoogleapis/python-bigquery-dataframes:tswast-polars-session-namesCopy head branch name to clipboard

Conversation

@tswast

@tswast tswast commented Oct 8, 2025

Copy link
Copy Markdown
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

tswast added 27 commits October 7, 2025 21:54
…ples

Also, fixes several constructors that didn't take a session for
compatibility with multi-session applications.
This reverts commit 765b678.
@product-auto-label product-auto-label Bot added size: xl Pull request size is extra large. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Oct 8, 2025
@tswast tswast requested review from a team and shuoweil October 8, 2025 22:30

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coverage failure. I think I should add # pragma: no cover to the currently skipped tests.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, I think it's the new methods on Session. Created #2157 which splits out that part and actually fixes a bug in the to_timedelta implementation.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: this file is a nearly exact copy of the tests/system/small/test_series.py file with additional fixtures for unit testing.

@tswast

tswast commented Oct 10, 2025

Copy link
Copy Markdown
Contributor Author

Failures appear unrelated.

e2e failure tests/system/large/blob/test_function.py::test_blob_transcribe[gemini-2.0-flash-lite-001-True]

samples failure multimodal_test.py::test_multimodal_dataframe - google.api_core.except...

@tswast tswast merged commit 6353d6e into main Oct 14, 2025
20 of 25 checks passed
@tswast tswast deleted the tswast-polars-session-names branch October 14, 2025 20:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: xl Pull request size is extra large.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.