Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Remove support for CodeQL 2.12.5 and earlier#2232

Merged
henrymercer merged 7 commits into
maingithub/codeql-action:mainfrom
henrymercer/remove-support-codeql-2.12.5github/codeql-action:henrymercer/remove-support-codeql-2.12.5Copy head branch name to clipboard
Apr 9, 2024
Merged

Remove support for CodeQL 2.12.5 and earlier#2232
henrymercer merged 7 commits into
maingithub/codeql-action:mainfrom
henrymercer/remove-support-codeql-2.12.5github/codeql-action:henrymercer/remove-support-codeql-2.12.5Copy head branch name to clipboard

Conversation

@henrymercer

Copy link
Copy Markdown
Contributor

Follow up to #2220 where we announced that support for CodeQL v2.12.5 and earlier would be removed after these versions were deprecated alongside GHES 3.8.

We'll need to update the set of required PR checks before merging this.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@henrymercer henrymercer requested a review from a team as a code owner April 9, 2024 11:35
angelapwen
angelapwen previously approved these changes Apr 9, 2024

@angelapwen angelapwen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 just one comment!!

Comment thread pr-checks/sync.py
'name': 'Set environment variable for Swift enablement',
'if': "runner.os != 'Windows' && matrix.version == '20221211'",
'shell': 'bash',
'run': 'echo "CODEQL_ENABLE_EXPERIMENTAL_FEATURES_SWIFT=true" >> $GITHUB_ENV'

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can remove this conditional too:

env.CODEQL_ENABLE_EXPERIMENTAL_FEATURES_SWIFT == 'true' ||
(requires a rebuild 🙇)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, agreed!

@angelapwen angelapwen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@henrymercer henrymercer merged commit 24a0170 into main Apr 9, 2024
@henrymercer henrymercer deleted the henrymercer/remove-support-codeql-2.12.5 branch April 9, 2024 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.