Merged
fix: bump shell-quote 1.7.3 → ^1.8.4 (GHSA-w7jw-789q-3m8p)#833
Conversation
Resolves critical Dependabot alerts #165 and #166. shell-quote < 1.8.4 does not escape newlines in object .op values in quote(). Craft only uses parse() on developer-controlled config, so not exploitable, but bumping clears the alerts. Also normalizes the import in publish.ts to a namespace import to match prepare.ts (correct form for a CJS module with no default export).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves the 2 open critical Dependabot alerts (#165 and #166) for
shell-quote.package.jsonpnpm-lock.yamlshell-quote < 1.8.4does not escape newlines in object.opvalues withinquote(). Craft only usesparse()on developer-controlled config strings (.craft.ymlpre/post-release commands), so it was not actually exploitable — but the bump clears the alerts.Changes
package.json:shell-quote1.7.3→^1.8.4pnpm-lock.yaml: regenerated (resolves1.8.4)src/commands/publish.ts: normalizedimport shellQuote from 'shell-quote'→import * as shellQuote from 'shell-quote'to matchprepare.ts(correct form for a CJS module with no default export)No breaking changes to
parse()or theParseEntrytype between 1.7.3 and 1.8.4.Verification
pnpm build✅pnpm test✅ (972 passed; the 7prepare-dry-run.e2efailures are a pre-existing env issue —EDITORunset in headless CI — unrelated to this change)pnpm lint✅ (0 errors)