fix(nuget): use unique suffix for global.json backup - #823
#823Merged
BYK merged 1 commit intoJun 4, 2026
getsentry:mastergetsentry/craft:masterfrom
jamescrosswell:fix/setversion-global-json-uniquejamescrosswell/craft:fix/setversion-global-json-uniqueCopy head branch name to clipboard
Merged
fix(nuget): use unique suffix for global.json backup#823BYK merged 1 commit intogetsentry:mastergetsentry/craft:masterfrom jamescrosswell:fix/setversion-global-json-uniquejamescrosswell/craft:fix/setversion-global-json-uniqueCopy head branch name to clipboard
BYK merged 1 commit into
getsentry:mastergetsentry/craft:masterfrom
jamescrosswell:fix/setversion-global-json-uniquejamescrosswell/craft:fix/setversion-global-json-uniqueCopy head branch name to clipboard
Conversation
Follow-up to getsentry#820. The backup path was a fixed `global.json.craft-bak`, which could theoretically clash if two craft invocations ran against the same working directory. Use `crypto.randomUUID()` to make the suffix unique per invocation. Refs: getsentry#820 (comment) Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
BYK
approved these changes
Jun 4, 2026
BYK
left a comment
Member
There was a problem hiding this comment.
Sorry it took me so long and thanks a lot for the follow up!!!
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #820, addressing BYK's review note.
The backup path was hardcoded to
global.json.craft-bak. If two craft invocations ever ran against the same working directory, the second would clobber the first's backup. Probability is very low in normal use (craft typically runs in a release-specific checkout), but a unique suffix costs nothing.Uses
crypto.randomUUID()to make the backup name unique per invocation.